You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "echuraev (via GitHub)" <gi...@apache.org> on 2023/05/09 07:48:03 UTC

[GitHub] [tvm] echuraev commented on issue #14805: [Bug][relay][pytorch] Wrong implementation logic in Threshold operator

echuraev commented on issue #14805:
URL: https://github.com/apache/tvm/issues/14805#issuecomment-1539624678

   @jikechao Thank you for your finds. IMHO, fixing frontend bugs is also very important work. TVM also cares about the accuracy because if we have a good performance but bad accuracy then it makes no sense because the final result is incorrect. By fixing such bugs and adding new operators support, you make a great contribution to model coverage by TVM. I think it is an important work.
   
   > Are you willing to give me some advice and suggestion on how to learn it?
   
   Also, it is my personal opinion, but usually I use [official documentation](https://tvm.apache.org/docs/index.html), you can find there many useful articles. E.g.:
   - Python API of Relay: https://tvm.apache.org/docs/reference/api/python/relay/index.html
   If you type `relay` in the search field, then you see many different articles related to relay and you can find something useful for you.
   
   Another trick which I commonly use, I try to find in the source code or in the git history something similar to my task and understand which components I have to modify. For example, if I need to add new operator support, I would find another commit which adds some another operator to TVM and learn how it was done. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org