[GitHub] [lucene] rmuir commented on pull request #11: LUCENE-9334 Consistency of field data structures

[GitBox <gi...@apache.org>]

rmuir commented on pull request #11:
URL: https://github.com/apache/lucene/pull/11#issuecomment-801583847


   this problem is a hard one, it makes the manual review difficult. 
   
   I think there is a pre-existing condition around this stuff with the tests, they are weak. It is part of what makes the review take too long, we can't trust the tests, so we try to cope in another way. No, its not fair to ask this problem to be fixed as part of this PR, I just want us to keep it in mind.
   
   there 2 new tests added here, but they a bit difficult to grok, for example each test has a text field, docvalues field, points field, vectors field.
   
   Could we arrange the tests better to make it easy to write lots of simpler tests?
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org