You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/31 05:09:39 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3748:
Remove two max size 500 limit.
wu-sheng commented on a change in pull request #3748: Remove two max size 500 limit.
URL: https://github.com/apache/skywalking/pull/3748#discussion_r340962223
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/cache/NetworkAddressInventoryCacheEsDAO.java
##########
@@ -84,7 +84,7 @@ public NetworkAddressInventoryCacheEsDAO(ElasticSearchClient client) {
try {
SearchSourceBuilder searchSourceBuilder = new SearchSourceBuilder();
searchSourceBuilder.query(QueryBuilders.rangeQuery(NetworkAddressInventory.LAST_UPDATE_TIME).gte(lastUpdateTime));
- searchSourceBuilder.size(500);
+ searchSourceBuilder.size(Integer.MAX_VALUE);
Review comment:
@JaredTan95 Yes, for sure. But it is hard to guarantee to load all? If not, the update is not working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services