You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "Marvel-Gu (via GitHub)" <gi...@apache.org> on 2025/01/25 00:00:19 UTC
[PR] [Improvement] Increase the default database connection pool max wait time (#3419) [amoro]
Marvel-Gu opened a new pull request, #3427:
URL: https://github.com/apache/amoro/pull/3427
… time (#3419)
## Why are the changes needed?
The default database connection pool max wait time is 1000ms for now.
This is quite small and the wait timeout exception is easy to occur when the database system is a bit busy.
Resolve #3419 .
## Brief change log
Change the default value of DB_CONNECT_MAX_WAIT_MILLIS to 30000 in AmoroManagementConf.java(amo-ams).
Change the default value of connection-pool-max-wait-millis to 30000 in amoro-configmap.yaml(charts) and config.yaml(dist).
The reason for choosing 30000 instead of 5000 is that the default connectionTimeout value of HikariCP is 30000 milliseconds (the default value of max-wait-millis of DBCP2 is -1), and the default values of mainstream database connection pools are almost 30000ms or larger.
## Documentation
Does this pull request introduce a new feature?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Increase the default database connection pool max wait time [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3427:
URL: https://github.com/apache/amoro/pull/3427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Increase the default database connection pool max wait time [amoro]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3427:
URL: https://github.com/apache/amoro/pull/3427#issuecomment-2613838388
## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3427?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 27.81%. Comparing base [(`decd55d`)](https://app.codecov.io/gh/apache/amoro/commit/decd55dec29e253d81e29ee960244d2999996432?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`599aeb5`)](https://app.codecov.io/gh/apache/amoro/commit/599aeb5a84624189c6fa9a47f8ef1e80f2fdd64d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 6 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3427 +/- ##
============================================
+ Coverage 21.64% 27.81% +6.16%
- Complexity 2316 3591 +1275
============================================
Files 427 599 +172
Lines 39751 48609 +8858
Branches 5630 6268 +638
============================================
+ Hits 8605 13520 +4915
- Misses 30419 34149 +3730
- Partials 727 940 +213
```
| [Flag](https://app.codecov.io/gh/apache/amoro/pull/3427/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core](https://app.codecov.io/gh/apache/amoro/pull/3427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.81% <100.00%> (?)` | |
| [trino](https://app.codecov.io/gh/apache/amoro/pull/3427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/3427?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org