You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/14 04:34:27 UTC
[GitHub] [superset] codecov-io edited a comment on pull request #12482: refactor(connectors): refactor sqla query generation
codecov-io edited a comment on pull request #12482:
URL: https://github.com/apache/superset/pull/12482#issuecomment-759186397
# [Codecov](https://codecov.io/gh/apache/superset/pull/12482?src=pr&el=h1) Report
> Merging [#12482](https://codecov.io/gh/apache/superset/pull/12482?src=pr&el=desc) (f96f129) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `0.11%`.
> The diff coverage is `92.78%`.
[](https://codecov.io/gh/apache/superset/pull/12482?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12482 +/- ##
==========================================
- Coverage 66.88% 66.76% -0.12%
==========================================
Files 1014 1016 +2
Lines 49513 49651 +138
Branches 5077 5081 +4
==========================================
+ Hits 33118 33151 +33
- Misses 16264 16370 +106
+ Partials 131 130 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `60.72% <ø> (+0.01%)` | :arrow_up: |
| python | `64.00% <92.78%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12482?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `84.00% <84.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.67% <95.83%> (+0.17%)` | :arrow_up: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <0.00%> (-25.65%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-9.76%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `89.39% <0.00%> (-5.61%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `67.61% <0.00%> (-4.83%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `58.90% <0.00%> (-4.48%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `70.96% <0.00%> (-4.04%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.51% <0.00%> (-3.59%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/superset/pull/12482/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12482?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12482?src=pr&el=footer). Last update [ff7b789...f96f129](https://codecov.io/gh/apache/superset/pull/12482?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org