You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/11/14 14:21:21 UTC

Review Request 15516: CLOUDSTACK-5169: Egress rules - Improved assertion code related to SSH to avoid assertion error

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15516/
-----------------------------------------------------------

Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.

Bugs: CLOUDSTACK-5169
https://issues.apache.org/jira/browse/CLOUDSTACK-5169

Repository: cloudstack-git

Description
-------

The SSH operation from one vm to other vm fails each time with different error message. It is either "Connection timed out", "No Route to host" or "Host key verification failed".
Now checking the error message from all the above 3 error messages to check that is SSH is successful or not.

Diffs
-----

test/integration/component/test_egress_rules.py 34995ff

Diff: https://reviews.apache.org/r/15516/diff/

Testing
-------

Tested locally on Xenserver Basic zone setup

Log:

test_authorizeIngressRule (test_egress_rules.TestAuthorizeIngressRule)
Test authorize ingress rule ... skipped 'Skip'
test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgress)
Test default group with egress rule before VM deploy and ping, ssh ... skipped 'skip'
test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgressAfterDeploy)
Test default group with egress rule added after vm deploy and ping, ... skipped 'Skip'
test_deployVM_InDefaultSecurityGroup (test_egress_rules.TestDefaultSecurityGroupEgress)
Test deploy VM in default security group with no egress rules ... skipped 'Skip'
test_invalid_account_authroize (test_egress_rules.TestInvalidAccountAuthroize)
Test invalid account authroize ... skipped 'Skip'
test_invalid_parameters (test_egress_rules.TestInvalidParametersForEgress)
Test invalid parameters for egress rules ... skipped 'Skip'
test_multiple_account_egress_rule_positive (test_egress_rules.TestMultipleAccountsEgressRule)
Test multiple account egress rules positive case ... skipped 'Skip'
test_multiple_account_egress_rule_negative (test_egress_rules.TestMultipleAccountsEgressRuleNeg)
Test multiple account egress rules negative case ... ok
test_revoke_egress_rule (test_egress_rules.TestRevokeEgressRule)
Test revoke security group egress rule ... skipped 'Skip'
test_start_stop_vm_egress (test_egress_rules.TestStartStopVMWithEgressRule)
Test stop start Vm with egress rules ... skipped 'Skip'

----------------------------------------------------------------------
Ran 10 tests in 80.718s

OK (skipped=9)

Thanks,

Ashutosh Kelkar

Re: Review Request 15516: CLOUDSTACK-5169: Egress rules - Improved assertion code related to SSH to avoid assertion error

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15516/#review28943
-----------------------------------------------------------


Commit b87f675f4abb9abff91b87dff5c6a087407427df in branch refs/heads/4.3 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b87f675 ]

CLOUDSTACK-5169: Egress rules - Improved assertion code
 related to SSH to avoid assertion error


- ASF Subversion and Git Services


On Nov. 14, 2013, 1:53 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15516/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5169
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5169
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The SSH operation from one vm to other vm fails each time with different error message. It is either "Connection timed out", "No Route to host" or "Host key verification failed".
> Now checking the error message from all the above 3 error messages to check that is SSH is successful or not.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_rules.py 34995ff 
> 
> Diff: https://reviews.apache.org/r/15516/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on Xenserver Basic zone setup
> 
> Log:
> 
> test_authorizeIngressRule (test_egress_rules.TestAuthorizeIngressRule)
> Test authorize ingress rule ... skipped 'Skip'
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgress)
> Test default group with egress rule before VM deploy and ping, ssh ... skipped 'skip'
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgressAfterDeploy)
> Test default group with egress rule added after vm deploy and ping, ... skipped 'Skip'
> test_deployVM_InDefaultSecurityGroup (test_egress_rules.TestDefaultSecurityGroupEgress)
> Test deploy VM in default security group with no egress rules ... skipped 'Skip'
> test_invalid_account_authroize (test_egress_rules.TestInvalidAccountAuthroize)
> Test invalid account authroize ... skipped 'Skip'
> test_invalid_parameters (test_egress_rules.TestInvalidParametersForEgress)
> Test invalid parameters for egress rules ... skipped 'Skip'
> test_multiple_account_egress_rule_positive (test_egress_rules.TestMultipleAccountsEgressRule)
> Test multiple account egress rules positive case ... skipped 'Skip'
> test_multiple_account_egress_rule_negative (test_egress_rules.TestMultipleAccountsEgressRuleNeg)
> Test multiple account egress rules negative case ... ok
> test_revoke_egress_rule (test_egress_rules.TestRevokeEgressRule)
> Test revoke security group egress rule ... skipped 'Skip'
> test_start_stop_vm_egress (test_egress_rules.TestStartStopVMWithEgressRule)
> Test stop start Vm with egress rules ... skipped 'Skip'
> 
> ----------------------------------------------------------------------
> Ran 10 tests in 80.718s
> 
> OK (skipped=9)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 15516: CLOUDSTACK-5169: Egress rules - Improved assertion code related to SSH to avoid assertion error

Posted by Girish Shilamkar <gi...@clogeny.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15516/#review28944
-----------------------------------------------------------

Ship it!


Committed to 4.2, 4.3 and master 

- Girish Shilamkar


On Nov. 14, 2013, 1:53 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15516/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5169
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5169
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The SSH operation from one vm to other vm fails each time with different error message. It is either "Connection timed out", "No Route to host" or "Host key verification failed".
> Now checking the error message from all the above 3 error messages to check that is SSH is successful or not.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_rules.py 34995ff 
> 
> Diff: https://reviews.apache.org/r/15516/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on Xenserver Basic zone setup
> 
> Log:
> 
> test_authorizeIngressRule (test_egress_rules.TestAuthorizeIngressRule)
> Test authorize ingress rule ... skipped 'Skip'
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgress)
> Test default group with egress rule before VM deploy and ping, ssh ... skipped 'skip'
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgressAfterDeploy)
> Test default group with egress rule added after vm deploy and ping, ... skipped 'Skip'
> test_deployVM_InDefaultSecurityGroup (test_egress_rules.TestDefaultSecurityGroupEgress)
> Test deploy VM in default security group with no egress rules ... skipped 'Skip'
> test_invalid_account_authroize (test_egress_rules.TestInvalidAccountAuthroize)
> Test invalid account authroize ... skipped 'Skip'
> test_invalid_parameters (test_egress_rules.TestInvalidParametersForEgress)
> Test invalid parameters for egress rules ... skipped 'Skip'
> test_multiple_account_egress_rule_positive (test_egress_rules.TestMultipleAccountsEgressRule)
> Test multiple account egress rules positive case ... skipped 'Skip'
> test_multiple_account_egress_rule_negative (test_egress_rules.TestMultipleAccountsEgressRuleNeg)
> Test multiple account egress rules negative case ... ok
> test_revoke_egress_rule (test_egress_rules.TestRevokeEgressRule)
> Test revoke security group egress rule ... skipped 'Skip'
> test_start_stop_vm_egress (test_egress_rules.TestStartStopVMWithEgressRule)
> Test stop start Vm with egress rules ... skipped 'Skip'
> 
> ----------------------------------------------------------------------
> Ran 10 tests in 80.718s
> 
> OK (skipped=9)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 15516: CLOUDSTACK-5169: Egress rules - Improved assertion code related to SSH to avoid assertion error

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15516/#review28945
-----------------------------------------------------------


Commit 6ac099e44c576b70e99779b6c14d1e38d6d6c95d in branch refs/heads/4.2 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6ac099e ]

CLOUDSTACK-5169: Egress rules - Improved assertion code
 related to SSH to avoid assertion error


- ASF Subversion and Git Services


On Nov. 14, 2013, 1:53 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15516/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5169
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5169
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The SSH operation from one vm to other vm fails each time with different error message. It is either "Connection timed out", "No Route to host" or "Host key verification failed".
> Now checking the error message from all the above 3 error messages to check that is SSH is successful or not.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_rules.py 34995ff 
> 
> Diff: https://reviews.apache.org/r/15516/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on Xenserver Basic zone setup
> 
> Log:
> 
> test_authorizeIngressRule (test_egress_rules.TestAuthorizeIngressRule)
> Test authorize ingress rule ... skipped 'Skip'
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgress)
> Test default group with egress rule before VM deploy and ping, ssh ... skipped 'skip'
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgressAfterDeploy)
> Test default group with egress rule added after vm deploy and ping, ... skipped 'Skip'
> test_deployVM_InDefaultSecurityGroup (test_egress_rules.TestDefaultSecurityGroupEgress)
> Test deploy VM in default security group with no egress rules ... skipped 'Skip'
> test_invalid_account_authroize (test_egress_rules.TestInvalidAccountAuthroize)
> Test invalid account authroize ... skipped 'Skip'
> test_invalid_parameters (test_egress_rules.TestInvalidParametersForEgress)
> Test invalid parameters for egress rules ... skipped 'Skip'
> test_multiple_account_egress_rule_positive (test_egress_rules.TestMultipleAccountsEgressRule)
> Test multiple account egress rules positive case ... skipped 'Skip'
> test_multiple_account_egress_rule_negative (test_egress_rules.TestMultipleAccountsEgressRuleNeg)
> Test multiple account egress rules negative case ... ok
> test_revoke_egress_rule (test_egress_rules.TestRevokeEgressRule)
> Test revoke security group egress rule ... skipped 'Skip'
> test_start_stop_vm_egress (test_egress_rules.TestStartStopVMWithEgressRule)
> Test stop start Vm with egress rules ... skipped 'Skip'
> 
> ----------------------------------------------------------------------
> Ran 10 tests in 80.718s
> 
> OK (skipped=9)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 15516: CLOUDSTACK-5169: Egress rules - Improved assertion code related to SSH to avoid assertion error

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15516/#review28942
-----------------------------------------------------------


Commit 9410423555d81f9da1c579f8d3c86b448bb9fee3 in branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9410423 ]

CLOUDSTACK-5169: Egress rules - Improved assertion code
 related to SSH to avoid assertion error


- ASF Subversion and Git Services


On Nov. 14, 2013, 1:53 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15516/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5169
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5169
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The SSH operation from one vm to other vm fails each time with different error message. It is either "Connection timed out", "No Route to host" or "Host key verification failed".
> Now checking the error message from all the above 3 error messages to check that is SSH is successful or not.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_rules.py 34995ff 
> 
> Diff: https://reviews.apache.org/r/15516/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on Xenserver Basic zone setup
> 
> Log:
> 
> test_authorizeIngressRule (test_egress_rules.TestAuthorizeIngressRule)
> Test authorize ingress rule ... skipped 'Skip'
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgress)
> Test default group with egress rule before VM deploy and ping, ssh ... skipped 'skip'
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgressAfterDeploy)
> Test default group with egress rule added after vm deploy and ping, ... skipped 'Skip'
> test_deployVM_InDefaultSecurityGroup (test_egress_rules.TestDefaultSecurityGroupEgress)
> Test deploy VM in default security group with no egress rules ... skipped 'Skip'
> test_invalid_account_authroize (test_egress_rules.TestInvalidAccountAuthroize)
> Test invalid account authroize ... skipped 'Skip'
> test_invalid_parameters (test_egress_rules.TestInvalidParametersForEgress)
> Test invalid parameters for egress rules ... skipped 'Skip'
> test_multiple_account_egress_rule_positive (test_egress_rules.TestMultipleAccountsEgressRule)
> Test multiple account egress rules positive case ... skipped 'Skip'
> test_multiple_account_egress_rule_negative (test_egress_rules.TestMultipleAccountsEgressRuleNeg)
> Test multiple account egress rules negative case ... ok
> test_revoke_egress_rule (test_egress_rules.TestRevokeEgressRule)
> Test revoke security group egress rule ... skipped 'Skip'
> test_start_stop_vm_egress (test_egress_rules.TestStartStopVMWithEgressRule)
> Test stop start Vm with egress rules ... skipped 'Skip'
> 
> ----------------------------------------------------------------------
> Ran 10 tests in 80.718s
> 
> OK (skipped=9)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 15516: CLOUDSTACK-5169: Egress rules - Improved assertion code related to SSH to avoid assertion error

Posted by Ashutosh Kelkar <as...@clogeny.com>.

(Updated Nov. 14, 2013, 1:53 p.m.)

Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.

Changes
-------

using batchmode while ssh just to check is ssh is possible

Bugs: CLOUDSTACK-5169
https://issues.apache.org/jira/browse/CLOUDSTACK-5169

Repository: cloudstack-git

Description
-------

Diffs (updated)
-----

test/integration/component/test_egress_rules.py 34995ff

Diff: https://reviews.apache.org/r/15516/diff/

Testing
-------

Tested locally on Xenserver Basic zone setup

Log:

----------------------------------------------------------------------
Ran 10 tests in 80.718s

OK (skipped=9)

Thanks,

Ashutosh Kelkar