You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/27 20:29:53 UTC

[GitHub] [arrow-datafusion] Dandandan commented on pull request #1059: fix and update window function sql tests

Dandandan commented on pull request #1059:
URL: https://github.com/apache/arrow-datafusion/pull/1059#issuecomment-928248613


   Changes are looking good to make the tests deterministic. I think it might be worthwhile to add now or later some tests for the now missing cases (first/last/nth) for non-ordered windows in empty over or only having `partition by`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org