You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/02/18 17:28:43 UTC
[GitHub] [httpcomponents-core] garydgregory opened a new pull request #265: 5.2.x misc cleanups
garydgregory opened a new pull request #265:
URL: https://github.com/apache/httpcomponents-core/pull/265
# Commit 1: Miscellaneous clean ups.
- Use isEmpty().
- Don't create empty arrays over and over.
- Don't nest else if you don't have to.
# Commit 2: Replace deprecated calls to Assert.assertThat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #265: 5.2.x misc cleanups
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #265:
URL: https://github.com/apache/httpcomponents-core/pull/265#issuecomment-781569356
@garydgregory Please bear with me for a few more weeks. I would like to release 5.1 GA soon, retire 5.0 and promote 5.2 to master. Then we should be back to just one stable (5.1) and one development (5.2) branches, which is going to make it easier to keep track of things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c edited a comment on pull request #265: 5.2.x misc cleanups
Posted by GitBox <gi...@apache.org>.
ok2c edited a comment on pull request #265:
URL: https://github.com/apache/httpcomponents-core/pull/265#issuecomment-781526205
@garydgregory Please see cb6cfd3202d203123f84b733ca61119041c6c364 in master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #265: 5.2.x misc cleanups
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #265:
URL: https://github.com/apache/httpcomponents-core/pull/265#issuecomment-781526205
@garydgregory Please see 35873412ba799f78c953898e93e02e512d1a5437 in master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory closed pull request #265: 5.2.x misc cleanups
Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #265:
URL: https://github.com/apache/httpcomponents-core/pull/265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #265: 5.2.x misc cleanups
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #265:
URL: https://github.com/apache/httpcomponents-core/pull/265#issuecomment-781525292
@garydgregory Please port this change-set to master or wait until `5.2.x` has been properly re-based off `master`. First off, I have already removed `Assert#assertThat` in master. Secondly, you now have competion with those misc cleanups commits. There is no need to do that in each and every branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #265: 5.2.x misc cleanups
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #265:
URL: https://github.com/apache/httpcomponents-core/pull/265#issuecomment-781561107
@ok2c
Oops, I should have paid closer attention to the state of the branches. Sorry for the noise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org