You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "cardigan1008 (via GitHub)" <gi...@apache.org> on 2023/07/25 18:55:07 UTC
[GitHub] [shardingsphere] cardigan1008 opened a new pull request, #27461: Enhance SQLNodeConverterEngine to support 'select_with_dollar_parameter_for_postgresql'
cardigan1008 opened a new pull request, #27461:
URL: https://github.com/apache/shardingsphere/pull/27461
Fixes #26871 .
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #27461: Enhance SQLNodeConverterEngine to support 'select_with_dollar_parameter_for_postgresql'
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #27461:
URL: https://github.com/apache/shardingsphere/pull/27461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on pull request #27461: Enhance SQLNodeConverterEngine to support 'select_with_dollar_parameter_for_postgresql'
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27461:
URL: https://github.com/apache/shardingsphere/pull/27461#issuecomment-1692334418
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cardigan1008 commented on pull request #27461: Enhance SQLNodeConverterEngine to support 'select_with_dollar_parameter_for_postgresql'
Posted by "cardigan1008 (via GitHub)" <gi...@apache.org>.
cardigan1008 commented on PR #27461:
URL: https://github.com/apache/shardingsphere/pull/27461#issuecomment-1650404803
Hi @strongduanmu . Before I reverted to this [commit](https://github.com/cardigan1008/shardingsphere/commit/8fe863ab5e7cc99c9cb81e0ba0d5dabbf7536181), my tests were all passing. However, after merging this commit, I encountered the error 'java.util.ServiceConfigurationError: org.apache.shardingsphere.infra.database.core.type.DatabaseType: Provider org.apache.shardingsphere.infra.database.mariadb.MariaDBDatabaseType could not be instantiated'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org