[GitHub] [lucene] msokolov commented on a diff in pull request #11790: Mark HNSW search results incomplete when fewer than topK are found

[GitBox <gi...@apache.org>]

msokolov commented on code in PR #11790:
URL: https://github.com/apache/lucene/pull/11790#discussion_r975881444


##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##########
@@ -267,6 +267,9 @@ private NeighborQueue searchLevel(
     while (results.size() > topK) {
       results.pop();
     }
+    if (level == 0 && results.size() < topK && numVisited < size) {

Review Comment:
   That's fair - this seems a bit risky, certainly more so than dropping the test.
   
   I thought this would work even when there is no filter, but I may have been confused?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org