You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "nitinware (via GitHub)" <gi...@apache.org> on 2026/09/27 04:56:20 UTC
[PR] [#20502] Remove nullness suppressions from the direct-java runner [beam]
nitinware opened a new pull request, #40295:
URL: https://github.com/apache/beam/pull/40295
## Summary
Removes the blanket `@SuppressWarnings("nullness")` suppressions from the `:runners:direct-java` module, resolving the nullness portion of #20502 (umbrella #20497).
All 36 files in the module now compile cleanly under the Checker Framework nullness checker with no blanket nullness suppression. `rawtypes` (#20447) and `keyfor` suppressions are preserved where present — only `nullness` was removed.
## Approach
- Wrapped genuine internal invariants with `org.apache.beam.sdk.util.Preconditions.checkStateNotNull` (guarded `firstEntry()`/`poll()` calls, registered-executable lookups, timer keys known non-null by construction).
- Annotated legitimately nullable fields, parameters, and returns with `@Nullable` to make the contracts explicit.
- Bounded internal type variables as `<... extends @NonNull Object>` where the checker requires `@NonNull` keys for map/collection lookups.
- Broke a construction cycle in `WatermarkManager` by moving per-transform watermark population out of the constructor into an `initializeTransformWatermarks()` method invoked from the static `create()` factory after the instance is fully initialized.
- Updated `PerKeyHolds` to track the single keyless (null-key) hold in a dedicated field so its `keyedHolds` map never requires a null key — O(1), with no suppression.
## Residual scoped suppression
`DirectPipelineResult.waitUntilFinish(Duration)` retains one narrow, commented `@SuppressWarnings("nullness")`.
`PipelineResult.waitUntilFinish(Duration)` in `sdk-core` is documented to return `null` on timeout, but its interface return type is not annotated `@Nullable`. Annotating the interface would affect overrides across multiple runners, so the timeout-null case is suppressed locally at this call site rather than changing the `sdk-core` API.
This follows the same precedent as `FlinkRunnerResult` and `JobServicePipelineResult`.
Therefore, #20502 is resolved as **no blanket nullness suppressions**, rather than literally zero scoped nullness suppressions.
## Testing
- `./gradlew :runners:direct-java:compileJava --rerun-tasks` — **BUILD SUCCESSFUL** (Checker Framework nullness checker clean)
- `./gradlew :runners:direct-java:spotlessJavaCheck :runners:direct-java:checkstyleMain` — **BUILD SUCCESSFUL**
- `WatermarkManagerTest` — **34 passed, 1 skipped, 0 failed**
Fixes #20502
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#20502] Remove nullness suppressions from the direct-java runner [beam]
Posted by "nitinware (via GitHub)" <gi...@apache.org>.
nitinware commented on PR #40295:
URL: https://github.com/apache/beam/pull/40295#issuecomment-5856814760
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#20502] Remove nullness suppressions from the direct-java runner [beam]
Posted by "nitinware (via GitHub)" <gi...@apache.org>.
nitinware commented on PR #40295:
URL: https://github.com/apache/beam/pull/40295#issuecomment-5871490521
@stankiewicz thanks for the review and merge! Appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#20502] Remove nullness suppressions from the direct-java runner [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz merged PR #40295:
URL: https://github.com/apache/beam/pull/40295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#20502] Remove nullness suppressions from the direct-java runner [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40295:
URL: https://github.com/apache/beam/pull/40295#issuecomment-5852785586
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#20502] Remove nullness suppressions from the direct-java runner [beam]
Posted by "nitinware (via GitHub)" <gi...@apache.org>.
nitinware commented on PR #40295:
URL: https://github.com/apache/beam/pull/40295#issuecomment-5852781394
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#20502] Remove nullness suppressions from the direct-java runner [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #40295:
URL: https://github.com/apache/beam/pull/40295#issuecomment-5869077090
nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#20502] Remove nullness suppressions from the direct-java runner [beam]
Posted by "nitinware (via GitHub)" <gi...@apache.org>.
nitinware commented on PR #40295:
URL: https://github.com/apache/beam/pull/40295#issuecomment-5860375913
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#20502] Remove nullness suppressions from the direct-java runner [beam]
Posted by "nitinware (via GitHub)" <gi...@apache.org>.
nitinware commented on PR #40295:
URL: https://github.com/apache/beam/pull/40295#issuecomment-5859125453
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org