You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/10/17 01:43:57 UTC

[kudu-CR] env util: remove ScopedFileDeleter 

Hello David Ribeiro Alves, Andrew Wong (DEPRECATED: please use awong@cloudera.com),

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8288

to review the following change.


Change subject: env_util: remove ScopedFileDeleter
......................................................................

env_util: remove ScopedFileDeleter

It's a holdover from before ScopedCleanup existed.

The intermingling of files and directories is a neat feature, but it's only
used in two places and isn't worth the complexity of a dedicated class.

Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tools/tool_action_pbc.cc
M src/kudu/util/env_util.cc
M src/kudu/util/env_util.h
M src/kudu/util/pb_util.cc
7 files changed, 64 insertions(+), 81 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/8288/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong (DEPRECATED: please use awong@cloudera.com) <an...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8288 )

Change subject: env_util: remove ScopedFileDeleter
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Oct 2017 19:30:34 +0000
Gerrit-HasComments: No

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8288 )

Change subject: env_util: remove ScopedFileDeleter
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Oct 2017 04:26:03 +0000
Gerrit-HasComments: No

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/8288 )

Change subject: env_util: remove ScopedFileDeleter
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8288 )

Change subject: env_util: remove ScopedFileDeleter
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8288/1/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:

http://gerrit.cloudera.org:8080/#/c/8288/1/src/kudu/fs/data_dirs.cc@380
PS1, Line 380:     // Delete directories in reverse order since parent directories
truncated?



-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Oct 2017 15:01:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Andrew Wong (DEPRECATED: please use awong@cloudera.com) from this change.  ( http://gerrit.cloudera.org:8080/8288 )

Change subject: env_util: remove ScopedFileDeleter
......................................................................


Removed reviewer Andrew Wong (DEPRECATED: please use awong@cloudera.com).
-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8288 )

Change subject: env_util: remove ScopedFileDeleter
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Oct 2017 19:47:20 +0000
Gerrit-HasComments: No

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8288 )

Change subject: env_util: remove ScopedFileDeleter
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8288/1/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:

http://gerrit.cloudera.org:8080/#/c/8288/1/src/kudu/fs/data_dirs.cc@380
PS1, Line 380:     // Delete directories in reverse order since parent directories
> truncated?
Oops, thought I fixed this. Done.



-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Oct 2017 18:54:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8288 )

Change subject: env_util: remove ScopedFileDeleter
......................................................................


Patch Set 2: Verified+1

Overriding Jenkins, unrelated test failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Oct 2017 20:21:49 +0000
Gerrit-HasComments: No

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8288 )

Change subject: env_util: remove ScopedFileDeleter
......................................................................

env_util: remove ScopedFileDeleter

It's a holdover from before ScopedCleanup existed.

The intermingling of files and directories is a neat feature, but it's only
used in two places and isn't worth the complexity of a dedicated class.

Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Reviewed-on: http://gerrit.cloudera.org:8080/8288
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tools/tool_action_pbc.cc
M src/kudu/util/env_util.cc
M src/kudu/util/env_util.h
M src/kudu/util/pb_util.cc
7 files changed, 65 insertions(+), 81 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, but someone else must approve
  Alexey Serbin: Looks good to me, approved
  Adar Dembo: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] env util: remove ScopedFileDeleter

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8288

to look at the new patch set (#2).

Change subject: env_util: remove ScopedFileDeleter
......................................................................

env_util: remove ScopedFileDeleter

It's a holdover from before ScopedCleanup existed.

The intermingling of files and directories is a neat feature, but it's only
used in two places and isn't worth the complexity of a dedicated class.

Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tools/tool_action_pbc.cc
M src/kudu/util/env_util.cc
M src/kudu/util/env_util.h
M src/kudu/util/pb_util.cc
7 files changed, 65 insertions(+), 81 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/8288/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>