You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/12 00:40:19 UTC

[GitHub] [iceberg] gustavoatt opened a new pull request #1323: End to end read support for int96 parquet timestamps

gustavoatt opened a new pull request #1323:
URL: https://github.com/apache/iceberg/pull/1323


   ## Summary
   
   Fixes https://github.com/apache/iceberg/issues/1138#issuecomment-670717050 by making sure that we can convert from `org.apache.parquet.schema.MessageType` to `org.apache.iceberg.types.Type`.
   
   The issue was occurring due to Iceberg not being able to map the `int96` type to an Iceberg Timestamp. Also added an end to end test to verify that we can read through Iceberg API the imported parquet file.
   
   While doing this, I noticed that the Iceberg generic parquet reader was reading the timestamp as timestamp without timezone instead of a timestamp with timezone.
   
   ## Testing
   
   Improved our current unit-test to handle this issue
   
   ## Reviewers
   
   to: @rdblue 
   cc: @thesquelched @aokolnychyi 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #1323: End to end read support for int96 parquet timestamps

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1323:
URL: https://github.com/apache/iceberg/pull/1323#issuecomment-672411035


   +1 when tests are passing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] thesquelched commented on pull request #1323: End to end read support for int96 parquet timestamps

Posted by GitBox <gi...@apache.org>.
thesquelched commented on pull request #1323:
URL: https://github.com/apache/iceberg/pull/1323#issuecomment-672910806


   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue merged pull request #1323: End to end read support for int96 parquet timestamps

Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1323:
URL: https://github.com/apache/iceberg/pull/1323


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #1323: End to end read support for int96 parquet timestamps

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1323:
URL: https://github.com/apache/iceberg/pull/1323#issuecomment-672435125


   Merged! Thanks @gustavoatt!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] gustavoatt commented on pull request #1323: End to end read support for int96 parquet timestamps

Posted by GitBox <gi...@apache.org>.
gustavoatt commented on pull request #1323:
URL: https://github.com/apache/iceberg/pull/1323#issuecomment-672448702


   Thanks for the fast review Ryan!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org