You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/03 15:19:45 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #10397:
[FLINK-15023][core][runtime] Remove on-heap managed memory
azagrebin commented on a change in pull request #10397: [FLINK-15023][core][runtime] Remove on-heap managed memory
URL: https://github.com/apache/flink/pull/10397#discussion_r353218861
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
##########
@@ -188,24 +179,14 @@ public MemorySize getTaskOffHeapMemory() {
return taskOffHeapMemory;
}
- /**
- * Get the on-heap managed memory needed.
- *
- * @return The on-heap managed memory
- */
- public MemorySize getOnHeapManagedMemory() {
- throwUnsupportedOperationExecptionIfUnknown();
- return onHeapManagedMemory;
- }
-
/**off
- * Get the off-heap managed memory needed.
+ * Get the managed memory needed.
Review comment:
Also typo in this commit message `fraom`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services