[GitHub] [incubator-heron] joshfischer1108 commented on a change in pull request #3413: Updating to fix deprecated Kubernetes APIs

[GitBox <gi...@apache.org>]

joshfischer1108 commented on a change in pull request #3413: Updating to fix deprecated Kubernetes APIs
URL: https://github.com/apache/incubator-heron/pull/3413#discussion_r355138510
 
 

 ##########
 File path: deploy/kubernetes/minikube/zookeeper.yaml
 ##########
 @@ -30,13 +30,31 @@ metadata:
 spec:
   serviceName: zookeeper
   replicas: 1
+  selector:
+    matchLabels:
+      app: heron
+      component: zookeeper
   template:
     metadata:
       labels:
         app: heron
         component: zookeeper
 
     spec:
+      # Make sure multiple pods of ZK don't get scheduled on the
+      # same node, unless there are no other available nodes
+      affinity:
+        podAntiAffinity:
 
 Review comment:
   Do we have podAntiAffinity set for the rest of the running components?  If not, do you think it would make sense to specify anitAffinity on the other tools in the system?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services