You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "lhutton1 (via GitHub)" <gi...@apache.org> on 2023/07/19 13:32:59 UTC
[GitHub] [tvm] lhutton1 opened a new pull request, #15359: [CMAKE] Conditionally link "clog" in NNPack install
lhutton1 opened a new pull request, #15359:
URL: https://github.com/apache/tvm/pull/15359
"cpuinfo" is a direct dependency of NNPack. It is installed via the NNPack's cmake script, but the version is not pinned. The "clog" dependency was recently removed from "cpuinfo"
(https://github.com/pytorch/cpuinfo/commit/3dc310302210c1891ffcfb12ae67b11a3ad3a150), which leads to issues when compiling TVM with support for NNPack.
When building TVM with newly generated docker images and NNPack enabled, we run into the following cmake configuration error:
```
The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files: NNPACK_CLOG_CONTRIB_LIB
```
This commit intends to fix this failure while also keeping compatibility with older versions of cpuinfo. It conditionally adds "clog" to the linker libs variable if it was found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm merged pull request #15359: [CMAKE] Conditionally link "clog" in NNPack install
Posted by "ashutosh-arm (via GitHub)" <gi...@apache.org>.
ashutosh-arm merged PR #15359:
URL: https://github.com/apache/tvm/pull/15359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15359: [CMAKE] Conditionally link "clog" in NNPack install
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15359:
URL: https://github.com/apache/tvm/pull/15359#issuecomment-1642093956
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `cmake` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org