You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "wernerdv (via GitHub)" <gi...@apache.org> on 2024/07/17 21:27:43 UTC
[PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
wernerdv opened a new pull request, #16620:
URL: https://github.com/apache/kafka/pull/16620
Added KRaft support to ControllerMutationQuotaTest.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #16620:
URL: https://github.com/apache/kafka/pull/16620#discussion_r1693223507
##########
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala:
##########
@@ -374,13 +395,15 @@ class ControllerMutationQuotaTest extends BaseRequestTest {
}
private def quotaMetric(user: String): Option[KafkaMetric] = {
- val metrics = servers.head.metrics
+ def metrics =
Review Comment:
Fixed
##########
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala:
##########
@@ -364,7 +385,7 @@ class ControllerMutationQuotaTest extends BaseRequestTest {
}
private def waitUserQuota(user: String, expectedQuota: Double): Unit = {
- val quotaManager = servers.head.quotaManagers.controllerMutation
+ val quotaManager = brokers.head.quotaManagers.controllerMutation
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #16620:
URL: https://github.com/apache/kafka/pull/16620#discussion_r1692851169
##########
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala:
##########
@@ -374,13 +395,15 @@ class ControllerMutationQuotaTest extends BaseRequestTest {
}
private def quotaMetric(user: String): Option[KafkaMetric] = {
- val metrics = servers.head.metrics
+ def metrics =
Review Comment:
This can be a `val`
##########
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala:
##########
@@ -364,7 +385,7 @@ class ControllerMutationQuotaTest extends BaseRequestTest {
}
private def waitUserQuota(user: String, expectedQuota: Double): Unit = {
- val quotaManager = servers.head.quotaManagers.controllerMutation
+ val quotaManager = brokers.head.quotaManagers.controllerMutation
Review Comment:
In KRaft mode should we check the QuotaManager on both `brokers.head` and `controllerServers.head`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on PR #16620:
URL: https://github.com/apache/kafka/pull/16620#issuecomment-2234354920
@mimaison Hello, PTAL.
To replace an irrelevant https://github.com/apache/kafka/pull/15038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on PR #16620:
URL: https://github.com/apache/kafka/pull/16620#issuecomment-2241517600
@chia7712 Hello, can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #16620:
URL: https://github.com/apache/kafka/pull/16620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org