You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/21 09:20:13 UTC
[GitHub] [shardingsphere-elasticjob] CaymanHK opened a new pull request #1475: Add download button by Cayman.
CaymanHK opened a new pull request #1475:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1475
Changes proposed in this pull request:
- Add download button by @CaymanHK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on pull request #1475: Add download button by Cayman.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #1475:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1475#issuecomment-696058520
The download url seems not working. [url](https://shardingsphere.apache.org/pdf/elasticjob_docs_en.pdf)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] CaymanHK closed pull request #1475: Add download button by Cayman.
Posted by GitBox <gi...@apache.org>.
CaymanHK closed pull request #1475:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on pull request #1475: Add download button by Cayman.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #1475:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1475#issuecomment-696058520
The download url seems not working. [url](https://shardingsphere.apache.org/pdf/elasticjob_docs_en.pdf)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] CaymanHK closed pull request #1475: Add download button by Cayman.
Posted by GitBox <gi...@apache.org>.
CaymanHK closed pull request #1475:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on a change in pull request #1475: Add download button by Cayman.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1475:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1475#discussion_r491971683
##########
File path: docs/themes/hugo-theme-learn/layouts/partials/menu.html
##########
@@ -84,6 +84,18 @@ <h3>{{ if not $disableShortcutsTitle}}{{ T "Shortcuts-Title"}}{{ end }}</h3>
</ul>
</section>
{{ end }}
+
+ <!-- download button -->
+ <hr />
+ {{ if eq .Lang "en"}}
+ <a class="padding" href="{{"https://shardingsphere.apache.org/pdf/elasticjob_docs_en.pdf" | absURL}}">
Review comment:
The download url seems not working
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on a change in pull request #1475: Add download button by Cayman.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1475:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1475#discussion_r491971683
##########
File path: docs/themes/hugo-theme-learn/layouts/partials/menu.html
##########
@@ -84,6 +84,18 @@ <h3>{{ if not $disableShortcutsTitle}}{{ T "Shortcuts-Title"}}{{ end }}</h3>
</ul>
</section>
{{ end }}
+
+ <!-- download button -->
+ <hr />
+ {{ if eq .Lang "en"}}
+ <a class="padding" href="{{"https://shardingsphere.apache.org/pdf/elasticjob_docs_en.pdf" | absURL}}">
Review comment:
The download url seems not working
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org