You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/10/20 08:07:51 UTC
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23559
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
This changelist introduces a new feature flag ARRAY_1D_COLUMN_TYPE
for Kudu tablet servers to reflect whether a tablet server is capable
of hosting tablets with array columns. Also, the system catalog's code
has been updated to require the feature flag when sending requests
to create a table with array type columns or altering a table
that contains at least one array type column.
The rationale behind adding the new feature flag is to make it easier
to reason about and troubleshoot situations when a Kudu master of newer
version works with tablet servers of prior versions, and the latter ones
do not support array type columns.
This patch includes test scenarios to provide basic coverage
for the newly introduced functionality.
Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
---
M src/kudu/client/service-features-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
5 files changed, 201 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/23559/1
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2006/
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 17:01:07 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 04:24:55 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 3:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/2020/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 05:55:49 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2021/
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 05:55:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2006/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 18:28:06 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2005/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 09:43:44 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
This changelist introduces a new feature flag ARRAY_1D_COLUMN_TYPE
for Kudu tablet servers to reflect whether a tablet server is capable
of hosting tablets with array columns. Also, the system catalog's code
has been updated to require the feature flag when sending requests
to create a table with array type columns or altering a table
that contains at least one array type column.
The rationale behind adding the new feature flag is to make it easier
to reason about and troubleshoot situations when a Kudu master of newer
version works with tablet servers of prior versions, and the latter ones
do not support array type columns.
This patch includes test scenarios to provide basic coverage
for the newly introduced functionality.
As a part of this changelist, I also updated the logic of the catalog
manager's RetryingTSRpcTask::RpcCallback() method to not retry sending
same RPC to tablet servers again and again if the tablet server responds
with 'unsupported feature flags'. This behavior is gated by the newly
introduced flag which is set to 'false' by default:
--catalog_manager_retry_tserver_task_on_unsupported_feature_flags
Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Reviewed-on: http://gerrit.cloudera.org:8080/23559
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/service-features-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
5 files changed, 227 insertions(+), 11 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2020/
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 05:29:23 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 4: Verified+1
unrelated test failures (TSAN): KUDU-3598, org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 16:59:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 2: Verified+1
unrelated test failures:
* RELEASE: TxnOpDispatcherITest.TestSeparateBeginCommitTestWorkloads
* TSAN: org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 21:02:14 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2005/
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 20 Oct 2025 08:08:01 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Xuebin Su, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23559
to look at the new patch set (#2).
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
This changelist introduces a new feature flag ARRAY_1D_COLUMN_TYPE
for Kudu tablet servers to reflect whether a tablet server is capable
of hosting tablets with array columns. Also, the system catalog's code
has been updated to require the feature flag when sending requests
to create a table with array type columns or altering a table
that contains at least one array type column.
The rationale behind adding the new feature flag is to make it easier
to reason about and troubleshoot situations when a Kudu master of newer
version works with tablet servers of prior versions, and the latter ones
do not support array type columns.
This patch includes test scenarios to provide basic coverage
for the newly introduced functionality.
As a part of this changelist, I also updated the logic of the catalog
manager's RetryingTSRpcTask::RpcCallback() method to not retry sending
same RPC to tablet servers again and again if the tablet server responds
with 'unsupported feature flags'. This behavior is gated by the newly
introduced flag which is set to 'false' by default:
--catalog_manager_retry_tserver_task_on_unsupported_feature_flags
Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
---
M src/kudu/client/service-features-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
5 files changed, 229 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/23559/2
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Xuebin Su, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23559
to look at the new patch set (#4).
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
This changelist introduces a new feature flag ARRAY_1D_COLUMN_TYPE
for Kudu tablet servers to reflect whether a tablet server is capable
of hosting tablets with array columns. Also, the system catalog's code
has been updated to require the feature flag when sending requests
to create a table with array type columns or altering a table
that contains at least one array type column.
The rationale behind adding the new feature flag is to make it easier
to reason about and troubleshoot situations when a Kudu master of newer
version works with tablet servers of prior versions, and the latter ones
do not support array type columns.
This patch includes test scenarios to provide basic coverage
for the newly introduced functionality.
As a part of this changelist, I also updated the logic of the catalog
manager's RetryingTSRpcTask::RpcCallback() method to not retry sending
same RPC to tablet servers again and again if the tablet server responds
with 'unsupported feature flags'. This behavior is gated by the newly
introduced flag which is set to 'false' by default:
--catalog_manager_retry_tserver_task_on_unsupported_feature_flags
Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
---
M src/kudu/client/service-features-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
5 files changed, 227 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/23559/4
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2021/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 16:50:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 introduce ARRAY 1D COLUMN TYPE feature for tservers
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5
Gerrit-Change-Number: 23559
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 16:18:41 +0000
Gerrit-HasComments: No