Re: wrong variable used in LeadServices, sfa webapp, marketing component

[Jacques Le Roux <ja...@les7arts.com>]

Thanks Dimitrios,

I don't think you created a Jira issue for this bug. Despites I fixed it in
trunk r1326503
R11.04 r1326504
R10.04  r1326505

If ever you, or someone else, created a Jira please close it

Thanks

Jacques

From: "Erwan de FERRIERES" <er...@gmail.com>
> Hi Dimitrios,
>
> submitting patches is done using JIRA.
> Here is the link: https://issues.apache.org/jira/browse/OFBIZ
>
> Thanks,
>
>
> 2012/2/12 Dimitrios Moustos <do...@office.lampero.ro>:
>> Hello,
>>
>> The relationship between lead owner and lead company is not expired when converting the lead.
>> The reason is that as the partyRelationship which is to be expired is looked up the party group information is taken from 
>> partyGroupPartyId, which does not exist.
>> The correct variable to use is partyGroupId. Please see the unbified patch bellow:
>>
>>
>> --- applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml Sun Feb 12 15:18:41 2012
>> +++ applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml Sun Feb 12 17:40:39 2012
>> @@ -165,7 +165,7 @@
>> <!-- Expire relation between lead company and its owner -->
>> <entity-and entity-name="PartyRelationship" list="partyRelationships" filter-by-date="true">
>> <field-map field-name="partyIdFrom" from-field="userLogin.partyId"/>
>> - <field-map field-name="partyIdTo" from-field="partyGroupPartyId"/>
>> + <field-map field-name="partyIdTo" from-field="partyGroupId"/>
>> <field-map field-name="roleTypeIdTo" value="ACCOUNT_LEAD"/>
>> <field-map field-name="roleTypeIdFrom" value="OWNER"/>
>> <order-by field-name="-fromDate"/>
>>
>>
>>
>> I hope this is helpful.
>
>
>
> -- 
> Erwan de FERRIERES
>