You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2011/09/03 00:15:28 UTC

Re: Error handling in PartyMapProcs.xml not working?

Which version are you using, did you trunk demo?

Jacques

From: "Jacques Le Roux" <ja...@les7arts.com>
> Please answer only on user ML...
> 
> The dev ML thread was opened for another reason, and I received also this message thru the OFBiz MLs, no needs to put my email on
> 
> I will have a look later...
> 
> Jacques
> 
> From: "Foo Shyn Chung" <ip...@gmail.com>
>> Hi Jacques,
>> 
>> Thanx for the answer. I'm just wondering, isn't the PartyMapProcs method
>> should act as a filter itself, and prompt the relevant error message from
>> the fail-property resource if it encounters error? But in this case it seems
>> like it didn't work.
>> 
>> I'm asking this because if the fail-property is working then there's a
>> better way to manage the error messages from my point of view.
>> 
>> Thanx
>> FooShyn
>> 
>> On Wed, Aug 31, 2011 at 11:23 AM, Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>> 
>>> Hi,
>>>
>>> All: It seems weird to me that updatePerson has those fields mandatory and
>>> not createPerson. I don't see any obvious reason to not have them
>>> consistent.
>>> So I think we should fix that.
>>>
>>> FooShyn: For your problem you should follow the same way and add your field
>>> as mandatory not only in your customisation of PartyMapProcs but also in
>>> createPerson/updatePerson
>>>
>>> Jacques
>>>
>>> From: "Foo Shyn Chung" <ip...@gmail.com>
>>>
>>>  Hi all,
>>>>
>>>> I was trying to add on a field to the Person entity, and to make this
>>>> field
>>>> a compulsory field.
>>>>
>>>> I added a check in the "person" map processor in the PartyMapProcs.xml as
>>>> below:
>>>>
>>>> <process field="nric"><copy/><not-**empty><fail-property
>>>> resource="PartyUiLabels" property="PartyNricMissing"/><**
>>>> /not-empty></process>
>>>>
>>>> and the relevant message in the PartyUiLabels.xml
>>>>
>>>> However when i try to test run, the form can actually be submitted
>>>> although
>>>> i didn't put in anything in the nric field. I found that for the First
>>>> Name
>>>> and Last Name field, during creation, i can leave it blank, while in the
>>>> update screen an error will be prompt.
>>>>
>>>> There was this attribute override being stated in the services.xml for
>>>> updatePerson service, while there are none for the createPerson service:
>>>>
>>>> <override name="firstName" optional="false"/>
>>>> <override name="lastName" optional="false"/>
>>>>
>>>>
>>>> Which leads me to ask, is the error handling in the PartyMapProcs.xml not
>>>> working? or am i missing something to make it work?
>>>>
>>>> Some pointer please, thanks!
>>>>
>>>> FooShyn
>>>>
>>>>
>>


Re: Error handling in PartyMapProcs.xml not working?

Posted by Jacques Le Roux <ja...@les7arts.com>.
Then I'd recommend either to switch to trunk or R11.04. It works correctly in both versions.
Or to introduces needed changes from them into 10.04, if you really need this release...

Jacques

From: "Foo Shyn Chung" <ip...@gmail.com>
>I was using 10.4...no i didn't trunk demo.
> 
> Thanx
> FooShyn
> 
> On Sat, Sep 3, 2011 at 6:15 AM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
> 
>> Which version are you using, did you trunk demo?
>>
>> Jacques
>>
>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>
>>  Please answer only on user ML...
>>>
>>> The dev ML thread was opened for another reason, and I received also this
>>> message thru the OFBiz MLs, no needs to put my email on
>>>
>>> I will have a look later...
>>>
>>> Jacques
>>>
>>> From: "Foo Shyn Chung" <ip...@gmail.com>
>>>
>>>> Hi Jacques,
>>>>
>>>> Thanx for the answer. I'm just wondering, isn't the PartyMapProcs method
>>>> should act as a filter itself, and prompt the relevant error message from
>>>> the fail-property resource if it encounters error? But in this case it
>>>> seems
>>>> like it didn't work.
>>>>
>>>> I'm asking this because if the fail-property is working then there's a
>>>> better way to manage the error messages from my point of view.
>>>>
>>>> Thanx
>>>> FooShyn
>>>>
>>>> On Wed, Aug 31, 2011 at 11:23 AM, Jacques Le Roux <
>>>> jacques.le.roux@les7arts.com> wrote:
>>>>
>>>>  Hi,
>>>>>
>>>>> All: It seems weird to me that updatePerson has those fields mandatory
>>>>> and
>>>>> not createPerson. I don't see any obvious reason to not have them
>>>>> consistent.
>>>>> So I think we should fix that.
>>>>>
>>>>> FooShyn: For your problem you should follow the same way and add your
>>>>> field
>>>>> as mandatory not only in your customisation of PartyMapProcs but also in
>>>>> createPerson/updatePerson
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Foo Shyn Chung" <ip...@gmail.com>
>>>>>
>>>>>  Hi all,
>>>>>
>>>>>>
>>>>>> I was trying to add on a field to the Person entity, and to make this
>>>>>> field
>>>>>> a compulsory field.
>>>>>>
>>>>>> I added a check in the "person" map processor in the PartyMapProcs.xml
>>>>>> as
>>>>>> below:
>>>>>>
>>>>>> <process field="nric"><copy/><not-****empty><fail-property
>>>>>> resource="PartyUiLabels" property="PartyNricMissing"/><****
>>>>>> /not-empty></process>
>>>>>>
>>>>>> and the relevant message in the PartyUiLabels.xml
>>>>>>
>>>>>> However when i try to test run, the form can actually be submitted
>>>>>> although
>>>>>> i didn't put in anything in the nric field. I found that for the First
>>>>>> Name
>>>>>> and Last Name field, during creation, i can leave it blank, while in
>>>>>> the
>>>>>> update screen an error will be prompt.
>>>>>>
>>>>>> There was this attribute override being stated in the services.xml for
>>>>>> updatePerson service, while there are none for the createPerson
>>>>>> service:
>>>>>>
>>>>>> <override name="firstName" optional="false"/>
>>>>>> <override name="lastName" optional="false"/>
>>>>>>
>>>>>>
>>>>>> Which leads me to ask, is the error handling in the PartyMapProcs.xml
>>>>>> not
>>>>>> working? or am i missing something to make it work?
>>>>>>
>>>>>> Some pointer please, thanks!
>>>>>>
>>>>>> FooShyn
>>>>>>
>>>>>>
>>>>>>
>>>>
>>
>


Re: Error handling in PartyMapProcs.xml not working?

Posted by Foo Shyn Chung <ip...@gmail.com>.
I was using 10.4...no i didn't trunk demo.

Thanx
FooShyn

On Sat, Sep 3, 2011 at 6:15 AM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:

> Which version are you using, did you trunk demo?
>
> Jacques
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
>
>  Please answer only on user ML...
>>
>> The dev ML thread was opened for another reason, and I received also this
>> message thru the OFBiz MLs, no needs to put my email on
>>
>> I will have a look later...
>>
>> Jacques
>>
>> From: "Foo Shyn Chung" <ip...@gmail.com>
>>
>>> Hi Jacques,
>>>
>>> Thanx for the answer. I'm just wondering, isn't the PartyMapProcs method
>>> should act as a filter itself, and prompt the relevant error message from
>>> the fail-property resource if it encounters error? But in this case it
>>> seems
>>> like it didn't work.
>>>
>>> I'm asking this because if the fail-property is working then there's a
>>> better way to manage the error messages from my point of view.
>>>
>>> Thanx
>>> FooShyn
>>>
>>> On Wed, Aug 31, 2011 at 11:23 AM, Jacques Le Roux <
>>> jacques.le.roux@les7arts.com> wrote:
>>>
>>>  Hi,
>>>>
>>>> All: It seems weird to me that updatePerson has those fields mandatory
>>>> and
>>>> not createPerson. I don't see any obvious reason to not have them
>>>> consistent.
>>>> So I think we should fix that.
>>>>
>>>> FooShyn: For your problem you should follow the same way and add your
>>>> field
>>>> as mandatory not only in your customisation of PartyMapProcs but also in
>>>> createPerson/updatePerson
>>>>
>>>> Jacques
>>>>
>>>> From: "Foo Shyn Chung" <ip...@gmail.com>
>>>>
>>>>  Hi all,
>>>>
>>>>>
>>>>> I was trying to add on a field to the Person entity, and to make this
>>>>> field
>>>>> a compulsory field.
>>>>>
>>>>> I added a check in the "person" map processor in the PartyMapProcs.xml
>>>>> as
>>>>> below:
>>>>>
>>>>> <process field="nric"><copy/><not-****empty><fail-property
>>>>> resource="PartyUiLabels" property="PartyNricMissing"/><****
>>>>> /not-empty></process>
>>>>>
>>>>> and the relevant message in the PartyUiLabels.xml
>>>>>
>>>>> However when i try to test run, the form can actually be submitted
>>>>> although
>>>>> i didn't put in anything in the nric field. I found that for the First
>>>>> Name
>>>>> and Last Name field, during creation, i can leave it blank, while in
>>>>> the
>>>>> update screen an error will be prompt.
>>>>>
>>>>> There was this attribute override being stated in the services.xml for
>>>>> updatePerson service, while there are none for the createPerson
>>>>> service:
>>>>>
>>>>> <override name="firstName" optional="false"/>
>>>>> <override name="lastName" optional="false"/>
>>>>>
>>>>>
>>>>> Which leads me to ask, is the error handling in the PartyMapProcs.xml
>>>>> not
>>>>> working? or am i missing something to make it work?
>>>>>
>>>>> Some pointer please, thanks!
>>>>>
>>>>> FooShyn
>>>>>
>>>>>
>>>>>
>>>
>