You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Maarten Mulders <mt...@apache.org> on 2024/05/24 11:09:40 UTC
Re: [DISCUSS] Removal of ineffective switch for Maven 4
On 24/05/2024 09:43, Michael Osipov wrote:
> On 2024/05/24 07:06:45 Maarten Mulders wrote:
>> Hi all,
>>
>> Today, I noticed Maven has an `-up` switch, for `--update-plugins`. The
>> help text says it's ineffective, only kept for backward compatibility.
>>
>> With the advent of Maven 4, would this be a good moment to remove this
>> switch?
>
> There much more of them to be killed, but before we do that we need to make sure that any of our plugins which invoke Maven never pass them, then we can discuss their removal.
Just checked, and indeed, there are a few more listed explicitly as
"ineffective":
-cpu, --check-plugin-updates
-npr, --no-plugin-registry
-npu, --no-plugin-updates
-up, --update-plugins
My idea would then be to see if any of these four are used in our own
code base (core as well as plugins). If there are usages, let's remove
them. That should not be hard, as they don't trigger any behaviour
anymore. After that, we can continue to drop them from the Maven CLI.
Would that make sense?
Maarten
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [DISCUSS] Removal of ineffective switch for Maven 4
Posted by Guillaume Nodet <gn...@apache.org>.
Le mar. 28 mai 2024 à 20:23, Maarten Mulders <mt...@apache.org> a
écrit :
> Yep, that commit was over 3 years ago... Yet Maven 3.8 and 3.9 have been
> released since that date, and both version series report having those
> options - although "ineffective".
>
>
Yes, that's because the 3.x branch has been created a long time ago.
>
> The good thing is that Maven 4 does not report them. So I'll leave it at
> that.
>
>
> Maarten
>
> On 25/05/2024 14:00, Guillaume Nodet wrote:
> > I think those have been removed 3 years ago...
> > https://issues.apache.org/jira/browse/MNG-6888
> >
> > Le ven. 24 mai 2024 à 13:10, Maarten Mulders <mt...@apache.org> a
> > écrit :
> >
> >> On 24/05/2024 09:43, Michael Osipov wrote:
> >>> On 2024/05/24 07:06:45 Maarten Mulders wrote:
> >>>> Hi all,
> >>>>
> >>>> Today, I noticed Maven has an `-up` switch, for `--update-plugins`.
> The
> >>>> help text says it's ineffective, only kept for backward compatibility.
> >>>>
> >>>> With the advent of Maven 4, would this be a good moment to remove this
> >>>> switch?
> >>>
> >>> There much more of them to be killed, but before we do that we need to
> >> make sure that any of our plugins which invoke Maven never pass them,
> then
> >> we can discuss their removal.
> >>
> >> Just checked, and indeed, there are a few more listed explicitly as
> >> "ineffective":
> >>
> >> -cpu, --check-plugin-updates
> >> -npr, --no-plugin-registry
> >> -npu, --no-plugin-updates
> >> -up, --update-plugins
> >>
> >> My idea would then be to see if any of these four are used in our own
> >> code base (core as well as plugins). If there are usages, let's remove
> >> them. That should not be hard, as they don't trigger any behaviour
> >> anymore. After that, we can continue to drop them from the Maven CLI.
> >>
> >> Would that make sense?
> >>
> >>
> >> Maarten
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
------------------------
Guillaume Nodet
Re: [DISCUSS] Removal of ineffective switch for Maven 4
Posted by Maarten Mulders <mt...@apache.org>.
Yep, that commit was over 3 years ago... Yet Maven 3.8 and 3.9 have been
released since that date, and both version series report having those
options - although "ineffective".
The good thing is that Maven 4 does not report them. So I'll leave it at
that.
Maarten
On 25/05/2024 14:00, Guillaume Nodet wrote:
> I think those have been removed 3 years ago...
> https://issues.apache.org/jira/browse/MNG-6888
>
> Le ven. 24 mai 2024 à 13:10, Maarten Mulders <mt...@apache.org> a
> écrit :
>
>> On 24/05/2024 09:43, Michael Osipov wrote:
>>> On 2024/05/24 07:06:45 Maarten Mulders wrote:
>>>> Hi all,
>>>>
>>>> Today, I noticed Maven has an `-up` switch, for `--update-plugins`. The
>>>> help text says it's ineffective, only kept for backward compatibility.
>>>>
>>>> With the advent of Maven 4, would this be a good moment to remove this
>>>> switch?
>>>
>>> There much more of them to be killed, but before we do that we need to
>> make sure that any of our plugins which invoke Maven never pass them, then
>> we can discuss their removal.
>>
>> Just checked, and indeed, there are a few more listed explicitly as
>> "ineffective":
>>
>> -cpu, --check-plugin-updates
>> -npr, --no-plugin-registry
>> -npu, --no-plugin-updates
>> -up, --update-plugins
>>
>> My idea would then be to see if any of these four are used in our own
>> code base (core as well as plugins). If there are usages, let's remove
>> them. That should not be hard, as they don't trigger any behaviour
>> anymore. After that, we can continue to drop them from the Maven CLI.
>>
>> Would that make sense?
>>
>>
>> Maarten
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [DISCUSS] Removal of ineffective switch for Maven 4
Posted by Guillaume Nodet <gn...@apache.org>.
I think those have been removed 3 years ago...
https://issues.apache.org/jira/browse/MNG-6888
Le ven. 24 mai 2024 à 13:10, Maarten Mulders <mt...@apache.org> a
écrit :
> On 24/05/2024 09:43, Michael Osipov wrote:
> > On 2024/05/24 07:06:45 Maarten Mulders wrote:
> >> Hi all,
> >>
> >> Today, I noticed Maven has an `-up` switch, for `--update-plugins`. The
> >> help text says it's ineffective, only kept for backward compatibility.
> >>
> >> With the advent of Maven 4, would this be a good moment to remove this
> >> switch?
> >
> > There much more of them to be killed, but before we do that we need to
> make sure that any of our plugins which invoke Maven never pass them, then
> we can discuss their removal.
>
> Just checked, and indeed, there are a few more listed explicitly as
> "ineffective":
>
> -cpu, --check-plugin-updates
> -npr, --no-plugin-registry
> -npu, --no-plugin-updates
> -up, --update-plugins
>
> My idea would then be to see if any of these four are used in our own
> code base (core as well as plugins). If there are usages, let's remove
> them. That should not be hard, as they don't trigger any behaviour
> anymore. After that, we can continue to drop them from the Maven CLI.
>
> Would that make sense?
>
>
> Maarten
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
------------------------
Guillaume Nodet
Re: [DISCUSS] Removal of ineffective switch for Maven 4
Posted by Karl Heinz Marbaise <kh...@gmx.de.INVALID>.
Hi,
+1 for removing them as well....
Kind regards
Karl Heinz Marbaise
On 24.05.24 13:09, Maarten Mulders wrote:
> On 24/05/2024 09:43, Michael Osipov wrote:
>> On 2024/05/24 07:06:45 Maarten Mulders wrote:
>>> Hi all,
>>>
>>> Today, I noticed Maven has an `-up` switch, for `--update-plugins`. The
>>> help text says it's ineffective, only kept for backward compatibility.
>>>
>>> With the advent of Maven 4, would this be a good moment to remove this
>>> switch?
>>
>> There much more of them to be killed, but before we do that we need to
>> make sure that any of our plugins which invoke Maven never pass them,
>> then we can discuss their removal.
>
> Just checked, and indeed, there are a few more listed explicitly as
> "ineffective":
>
> -cpu, --check-plugin-updates
> -npr, --no-plugin-registry
> -npu, --no-plugin-updates
> -up, --update-plugins
>
> My idea would then be to see if any of these four are used in our own
> code base (core as well as plugins). If there are usages, let's remove
> them. That should not be hard, as they don't trigger any behaviour
> anymore. After that, we can continue to drop them from the Maven CLI.
>
> Would that make sense?
>
>
> Maarten
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [DISCUSS] Removal of ineffective switch for Maven 4
Posted by Matthias Bünger <ru...@web.de.INVALID>.
For me it does and we should take the oppurtunity with Maven 4 to do so
Greetings
Matthias
Am 24.05.2024 um 13:09 schrieb Maarten Mulders:
> On 24/05/2024 09:43, Michael Osipov wrote:
>> On 2024/05/24 07:06:45 Maarten Mulders wrote:
>>> Hi all,
>>>
>>> Today, I noticed Maven has an `-up` switch, for `--update-plugins`. The
>>> help text says it's ineffective, only kept for backward compatibility.
>>>
>>> With the advent of Maven 4, would this be a good moment to remove this
>>> switch?
>>
>> There much more of them to be killed, but before we do that we need
>> to make sure that any of our plugins which invoke Maven never pass
>> them, then we can discuss their removal.
>
> Just checked, and indeed, there are a few more listed explicitly as
> "ineffective":
>
> -cpu, --check-plugin-updates
> -npr, --no-plugin-registry
> -npu, --no-plugin-updates
> -up, --update-plugins
>
> My idea would then be to see if any of these four are used in our own
> code base (core as well as plugins). If there are usages, let's remove
> them. That should not be hard, as they don't trigger any behaviour
> anymore. After that, we can continue to drop them from the Maven CLI.
>
> Would that make sense?
>
>
> Maarten
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [DISCUSS] Removal of ineffective switch for Maven 4
Posted by Bernd Eckenfels <ec...@zusammenkunft.net>.
>> My idea would then be to see if any of these four are used in our own
>> code base (core as well as plugins). If there are usages, let's remove
>> them. That should not be hard, as they don't trigger any behaviour
>> anymore. After that, we can continue to drop them from the Maven CLI.
>>
>> Would that make sense?
>
> That would make sense.
If the investigation takes longer, you can
at least remove them from usage output
I had glanced over those options more
often than I like, just to learn they are
Ineffective,
Gruß
Bernd
—
https://bernd.eckenfels.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [DISCUSS] Removal of ineffective switch for Maven 4
Posted by Michael Osipov <mi...@apache.org>.
Am 2024-05-24 um 13:09 schrieb Maarten Mulders:
> On 24/05/2024 09:43, Michael Osipov wrote:
>> On 2024/05/24 07:06:45 Maarten Mulders wrote:
>>> Hi all,
>>>
>>> Today, I noticed Maven has an `-up` switch, for `--update-plugins`. The
>>> help text says it's ineffective, only kept for backward compatibility.
>>>
>>> With the advent of Maven 4, would this be a good moment to remove this
>>> switch?
>>
>> There much more of them to be killed, but before we do that we need to
>> make sure that any of our plugins which invoke Maven never pass them,
>> then we can discuss their removal.
>
> Just checked, and indeed, there are a few more listed explicitly as
> "ineffective":
>
> -cpu, --check-plugin-updates
> -npr, --no-plugin-registry
> -npu, --no-plugin-updates
> -up, --update-plugins
>
> My idea would then be to see if any of these four are used in our own
> code base (core as well as plugins). If there are usages, let's remove
> them. That should not be hard, as they don't trigger any behaviour
> anymore. After that, we can continue to drop them from the Maven CLI.
>
> Would that make sense?
That would make sense.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org