You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2012/11/28 21:39:58 UTC
[jira] [Created] (THRIFT-1765) Incorrect error message printed for
null or negative keys
Jens Geyer created THRIFT-1765:
----------------------------------
Summary: Incorrect error message printed for null or negative keys
Key: THRIFT-1765
URL: https://issues.apache.org/jira/browse/THRIFT-1765
Project: Thrift
Issue Type: Bug
Components: Compiler (General)
Environment: MinGW, Windows
Reporter: Jens Geyer
Fix For: 1.0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1765) Incorrect error message printed for
null or negative keys
Posted by "Jens Geyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Geyer updated THRIFT-1765:
-------------------------------
Description:
The following IDL file
{code}
struct test {
0 : string zero,
1 : string one,
2 : string two
}
{code}
produced this Output:
{code}
c:\> thrift --allow-neg-keys -gen csharp .\testcase.thrift
Scanning testcase for includes
[WARNING:testcase:2] Negative field key (0) differs from what would be auto-assigned by thrift (0).
{code}
which is obviously wrong, since the latter value is of course -1, but not 0.
> Incorrect error message printed for null or negative keys
> ---------------------------------------------------------
>
> Key: THRIFT-1765
> URL: https://issues.apache.org/jira/browse/THRIFT-1765
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Environment: MinGW, Windows
> Reporter: Jens Geyer
> Fix For: 1.0
>
>
> The following IDL file
> {code}
> struct test {
> 0 : string zero,
> 1 : string one,
> 2 : string two
> }
> {code}
> produced this Output:
> {code}
> c:\> thrift --allow-neg-keys -gen csharp .\testcase.thrift
> Scanning testcase for includes
> [WARNING:testcase:2] Negative field key (0) differs from what would be auto-assigned by thrift (0).
> {code}
> which is obviously wrong, since the latter value is of course -1, but not 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1765) Incorrect error message printed for
null or negative keys
Posted by "Jens Geyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Geyer updated THRIFT-1765:
-------------------------------
Patch Info: Patch Available
> Incorrect error message printed for null or negative keys
> ---------------------------------------------------------
>
> Key: THRIFT-1765
> URL: https://issues.apache.org/jira/browse/THRIFT-1765
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Environment: MinGW, Windows
> Reporter: Jens Geyer
> Fix For: 1.0
>
>
> The following IDL file
> {code}
> struct test {
> 0 : string zero,
> 1 : string one,
> 2 : string two
> }
> {code}
> produced this Output:
> {code}
> c:\> thrift --allow-neg-keys -gen csharp .\testcase.thrift
> Scanning testcase for includes
> [WARNING:testcase:2] Negative field key (0) differs from what would be auto-assigned by thrift (0).
> {code}
> which is obviously wrong, since the latter value is of course -1, but not 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1765) Incorrect error message printed for
null or negative keys
Posted by "Jens Geyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Geyer updated THRIFT-1765:
-------------------------------
Attachment: THRIFT-1765_Incorrect_error_message_printed_for_null_or_negative_keys.patch
Proposed patch. The $1 value is an 64bit integer, thus cannot be printf'ed with %d.
> Incorrect error message printed for null or negative keys
> ---------------------------------------------------------
>
> Key: THRIFT-1765
> URL: https://issues.apache.org/jira/browse/THRIFT-1765
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Environment: MinGW, Windows
> Reporter: Jens Geyer
> Fix For: 1.0
>
> Attachments: THRIFT-1765_Incorrect_error_message_printed_for_null_or_negative_keys.patch
>
>
> The following IDL file
> {code}
> struct test {
> 0 : string zero,
> 1 : string one,
> 2 : string two
> }
> {code}
> produced this Output:
> {code}
> c:\> thrift --allow-neg-keys -gen csharp .\testcase.thrift
> Scanning testcase for includes
> [WARNING:testcase:2] Negative field key (0) differs from what would be auto-assigned by thrift (0).
> {code}
> which is obviously wrong, since the latter value is of course -1, but not 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira