[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #350: GUACAMOLE-943 Fixed incorrect sequence for SSH and telnet when shift key is held.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #350:
URL: https://github.com/apache/guacamole-server/pull/350#discussion_r743319809



##########
File path: src/terminal/terminal.c
##########
@@ -1590,6 +1590,23 @@ static int __guac_terminal_send_key(guac_terminal* term, int keysym, int pressed
                 if (keysym == 0xFF54 || keysym == 0xFF99) return guac_terminal_send_string(term, "\x1B[B"); /* Down */
             }
 
+            if (term->mod_shift) 
+            {

Review comment:
       Please use the same style as the established code with respect to the `if` and the `{`. For example:
   
   https://github.com/apache/guacamole-server/blob/491be8382acfc682a356284701a8535e4e73dd47/src/terminal/terminal.c#L1580
   
   See: https://guacamole.apache.org/guac-style/#braces




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org