You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/17 19:58:01 UTC
[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module
for easier maintenance
[ https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329345#comment-16329345 ]
ASF GitHub Bot commented on CB-13309:
-------------------------------------
infil00p commented on issue #242: CB-13309: InAppBrowser as a Library Project
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242#issuecomment-358424993
Sadly, this conflicts hard with the programmatic approach that people want to adopt, so I'm going to close this for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Make InAppBrowser a Library Module for easier maintenance
> ---------------------------------------------------------
>
> Key: CB-13309
> URL: https://issues.apache.org/jira/browse/CB-13309
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-inappbrowser
> Reporter: Joe Bowser
> Priority: Major
>
> We currently just copy in Java files directly in a project, but that has some major problems with layouts and resources. Now that Android allows Library Projects, we can now add modules as plugins and allow for certain plugins which require layouts (like the InAppBrowser) to define them in XML instead of programmatically, which will allow for a lot of code to be deleted from the project, and for the project to be easier to maintain for Android.
> Another upshot of this change is that we can then add JUnit and Espresso Integration Tests to plugins so that we can actually test plugin changes the same way we run native tests on Android with the Android Test Project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org