You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/08/29 14:49:02 UTC
Review Request 61969: Database consistency check fails after upgrade
to ambari 2.6.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61969/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Sid Wagle.
Bugs: AMBARI-21843
https://issues.apache.org/jira/browse/AMBARI-21843
Repository: ambari
Description
-------
Here we need to fix two issues:
1) Table "clusterconfigmapping" was removed in ambari-2.6.0 (dropping it during upgrade). But db consistency check still using this table to get some data. After upgrade it fails because "clusterconfigmapping" doesn't exist. Need to reimplement checks which are using this table.
2) Db consistency check doesn't show any information for user about errors, in casse when table doesn't exist. You can check that with "clusterconfigmapping"
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java aa96875
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 5ce03a3
Diff: https://reviews.apache.org/r/61969/diff/1/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 61969: Database consistency check fails after
upgrade to ambari 2.6.0
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61969/#review184066
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Aug. 29, 2017, 2:55 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61969/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2017, 2:55 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
>
>
> Bugs: AMBARI-21843
> https://issues.apache.org/jira/browse/AMBARI-21843
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Here we need to fix two issues:
> 1) Table "clusterconfigmapping" was removed in ambari-2.6.0 (dropping it during upgrade). But db consistency check still using this table to get some data. After upgrade it fails because "clusterconfigmapping" doesn't exist. Need to reimplement checks which are using this table.
> 2) Db consistency check doesn't show any information for user about errors, in casse when table doesn't exist. You can check that with "clusterconfigmapping"
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java aa96875
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 5ce03a3
>
>
> Diff: https://reviews.apache.org/r/61969/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 61969: Database consistency check fails after
upgrade to ambari 2.6.0
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61969/
-----------------------------------------------------------
(Updated Сер. 29, 2017, 2:55 після полудня)
Review request for Ambari, Jonathan Hurley and Sid Wagle.
Bugs: AMBARI-21843
https://issues.apache.org/jira/browse/AMBARI-21843
Repository: ambari
Description
-------
Here we need to fix two issues:
1) Table "clusterconfigmapping" was removed in ambari-2.6.0 (dropping it during upgrade). But db consistency check still using this table to get some data. After upgrade it fails because "clusterconfigmapping" doesn't exist. Need to reimplement checks which are using this table.
2) Db consistency check doesn't show any information for user about errors, in casse when table doesn't exist. You can check that with "clusterconfigmapping"
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java aa96875
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 5ce03a3
Diff: https://reviews.apache.org/r/61969/diff/2/
Changes: https://reviews.apache.org/r/61969/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 61969: Database consistency check fails after
upgrade to ambari 2.6.0
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61969/#review184057
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 29, 2017, 10:49 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61969/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2017, 10:49 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
>
>
> Bugs: AMBARI-21843
> https://issues.apache.org/jira/browse/AMBARI-21843
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Here we need to fix two issues:
> 1) Table "clusterconfigmapping" was removed in ambari-2.6.0 (dropping it during upgrade). But db consistency check still using this table to get some data. After upgrade it fails because "clusterconfigmapping" doesn't exist. Need to reimplement checks which are using this table.
> 2) Db consistency check doesn't show any information for user about errors, in casse when table doesn't exist. You can check that with "clusterconfigmapping"
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java aa96875
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 5ce03a3
>
>
> Diff: https://reviews.apache.org/r/61969/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>