Re[2]: [OT] [ANN] Spring Modules: jcr-support upgrade

[Costin Leau <co...@gmail.com>]

> I have some more (tech) feedback:

> 1/ an org.springmodules.jcr.JcrTemplate needs an
> org.springmodules.SessionFactory; but the 
> JcrSessionFactory does not implement the a/m interface, even if the API looks the same (something
> like duck typing ;-) )
Obviously a mistake.

> 2/ in samples/jcr/src the applicationContext-local and
> applicationContext-jr-local are exactly the same.

Fixed (removed appContext-local).

>>> Also I have noticed a small problem in LocalTransactionManager:
>>> 
>>> [code]
>>>      public void setRepository(SessionFactory sessionFactory) {
>>>          this.sessionFactory = sessionFactory;
>>>      }
>>> [/code]
>>> 
>>> and later
>>> 
>>> [code]
>>>      public void setSessionFactory(SessionFactory sessionFactory) {
>>>          this.sessionFactory = sessionFactory;
>>>      }
>>> [/code]
>>> 
>>> I guess the first 1 is either has a wrong signature, or it is a duplicate of the 2nd one.
>>> 

The first method was removed - it was a left-over from the
pre-refactoring era :). Thanks.
I've just commited the fixes on the CVS.
-- 
Best regards,
 Costin                            mailto:costin.leau@gmail.com