[GitHub] [beam] rohdesamuel commented on a change in pull request #15165: [BEAM-12593] Verify DataFrame API on pandas 1.3.0

[GitBox <gi...@apache.org>]

rohdesamuel commented on a change in pull request #15165:
URL: https://github.com/apache/beam/pull/15165#discussion_r671461625



##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -491,12 +503,13 @@ def test_series_tests(self):
                 # Inspection after modification.
                 's'
             ],
+            'pandas.core.series.Series.resample': ['df'],
         })
     self.assertEqual(result.failed, 0)
 
   def test_string_tests(self):
-    PD_VERSION = tuple(int(v) for v in pd.__version__.split('.'))
-    if PD_VERSION < (1, 2, 0):
+    PD_VERSION = tuple(int(v) for v in pd.__version__.split('.')[:2])

Review comment:
       Rewritten to get the PD_VERSION from frames.py. Probably not worth it to keep the patch veresion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org