You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/14 17:03:49 UTC

[GitHub] [pulsar] liangyepianzhou opened a new pull request, #15177: [Doc] Add missing parameters to CommandAck

liangyepianzhou opened a new pull request, #15177:
URL: https://github.com/apache/pulsar/pull/15177

   Fix https://github.com/apache/pulsar/issues/11272
   ### Motivation & Modification
   Add missing parameters to CommandAck.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `no-need-doc` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [x] `doc-added`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r852547251


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC, 
+   uniquely identify a transaction with `txnid_most_bits`
+ * `request_id` -> *(optional)* Id for handling response and timeout

Review Comment:
   We can use "ID" here 
   rules: https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.je5thtkj42cb



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851206435


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC, 
+   uniquely identify a transaction with `txnid_most_bits`
+ * `request_id` -> *(optional)* Id for handling response and timeout

Review Comment:
   I also think it may be better to use ID, but other similar places in this file use Id. Is it inappropriate for us to modify the Id here alone?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851852524


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`

Review Comment:
   @liangyepianzhou I see you do not incorporate comments for "ID", can you explain why? Thanks



##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`

Review Comment:
   @liangyepianzhou I see you do not incorporate comments for "ID", can you explain your concern? Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r852678745


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -406,12 +406,19 @@ message CommandAck {
 ```
 
 Parameters:
- * `consumer_id` → Id of an already established consumer
+ * `consumer_id` → ID of an already established consumer
  * `ack_type` → Type of acknowledgment: `Individual` or `Cumulative`
- * `message_id` → Id of the message to acknowledge
+ * `message_id` → ID of the message to acknowledge
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC ID, `txnid_most_bits` and `txnid_least_bits`
+   uniquely identify a transaction.
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC,

Review Comment:
   This is the id, not the Id, also need to be changed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] congbobo184 merged pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
congbobo184 merged PR #15177:
URL: https://github.com/apache/pulsar/pull/15177


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#issuecomment-1099415044

   @liangyepianzhou:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r852548445


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC, 
+   uniquely identify a transaction with `txnid_most_bits`
+ * `request_id` -> *(optional)* Id for handling response and timeout

Review Comment:
   Ok, I will refine this in this file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r852678745


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -406,12 +406,19 @@ message CommandAck {
 ```
 
 Parameters:
- * `consumer_id` → Id of an already established consumer
+ * `consumer_id` → ID of an already established consumer
  * `ack_type` → Type of acknowledgment: `Individual` or `Cumulative`
- * `message_id` → Id of the message to acknowledge
+ * `message_id` → ID of the message to acknowledge
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC ID, `txnid_most_bits` and `txnid_least_bits`
+   uniquely identify a transaction.
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC,

Review Comment:
   This is id, not Id, also need to be changed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851014807


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC, 

Review Comment:
   similar question to the last comment



##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`

Review Comment:
   ```suggestion
    * `txnid_most_bits` -> *(optional)* Same as TC ID. It uniquely identifies a transaction with `txnid_most_bits`
   ```
   
   do you mean this？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851213312


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC, 
+   uniquely identify a transaction with `txnid_most_bits`
+ * `request_id` -> *(optional)* Id for handling response and timeout

Review Comment:
   And it feels like Id will look more familiar to engineer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r852678745


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -406,12 +406,19 @@ message CommandAck {
 ```
 
 Parameters:
- * `consumer_id` → Id of an already established consumer
+ * `consumer_id` → ID of an already established consumer
  * `ack_type` → Type of acknowledgment: `Individual` or `Cumulative`
- * `message_id` → Id of the message to acknowledge
+ * `message_id` → ID of the message to acknowledge
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC ID, `txnid_most_bits` and `txnid_least_bits`
+   uniquely identify a transaction.
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC,

Review Comment:
   This is id, not Id, also need to be changed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851183197


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`

Review Comment:
   * `txnid_most_bits` -> *(optional)* Same as TC ID. It uniquely identifies a transaction with `txnid_least_bits `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851193977


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC, 

Review Comment:
   similar



##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC, 
+   uniquely identify a transaction with `txnid_most_bits`
+ * `request_id` -> *(optional)* Id for handling response and timeout

Review Comment:
   ```suggestion
    * `request_id` -> *(optional)* ID for handling response and timeout.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r852666496


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -406,12 +406,19 @@ message CommandAck {
 ```
 
 Parameters:
- * `consumer_id` → Id of an already established consumer
+ * `consumer_id` → ID of an already established consumer
  * `ack_type` → Type of acknowledgment: `Individual` or `Cumulative`
- * `message_id` → Id of the message to acknowledge
+ * `message_id` → ID of the message to acknowledge
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC ID, `txnid_most_bits` and `txnid_least_bits`
+   uniquely identify a transaction.
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC,

Review Comment:
   you miss this occurrence 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851193626


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`

Review Comment:
   Then we should explain it in a more clear way, eg, 
   ```suggestion
    * `txnid_most_bits` -> *(optional)* Same as TC ID. `txnid_most_bits` and `txnid_least_bits`uniquely identify a transaction.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851014807


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC, 

Review Comment:
   similar question to the last comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15177: [Doc] Add missing parameters to CommandAck

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851184203


##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
  * `validation_error` → *(optional)* Indicates that the consumer has discarded
    the messages due to: `UncompressedSizeCorruption`,
    `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a transaction with `txnid_least_bits`

Review Comment:
   I mean `txnid_most_bits` and `txnid_least_bits` together uniquely identify a transaction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org