You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/25 23:42:49 UTC
[GitHub] [airflow] lsimoneau opened a new pull request #7879: [AIRFLOW-6399]
Serialization: DAG access_control field should be decorated field in DAG
serialization
lsimoneau opened a new pull request #7879: [AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization
URL: https://github.com/apache/airflow/pull/7879
This is a modification of #7374 to fix a failing test caused by inconsistent ordering between the serialized DAG and the ground truth DAG.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7879: [AIRFLOW-6399]
Serialization: DAG access_control field should be decorated field in DAG
serialization
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7879: [AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization
URL: https://github.com/apache/airflow/pull/7879#issuecomment-604538981
Yeah. Travis got wuiyr unstable those days. I restarted it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7879: [AIRFLOW-6399]
Serialization: DAG access_control field should be decorated field in DAG
serialization
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7879: [AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization
URL: https://github.com/apache/airflow/pull/7879#issuecomment-604720219
> @kaxil thanks for that. Can I ask if you expect this to be released in a version before 2.0? We rely on serialisation for some of our cluster monitoring, and are trying to roll out RBAC now but this is a blocker. Otherwise we may try building off a fork for now, but wanted to check with you if there were more bugfix releases coming before 2.0.
Yes this will be included in Airflow 1.10.10 which is expected to be released by early to mid-April (next Month)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7879: [AIRFLOW-6399]
Serialization: DAG access_control field should be decorated field in DAG
serialization
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7879: [AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization
URL: https://github.com/apache/airflow/pull/7879#issuecomment-604667676
Thanks @lsimoneau and @codenamelxl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7879:
[AIRFLOW-6399] Serialization: DAG access_control field should be decorated
field in DAG serialization
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7879: [AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization
URL: https://github.com/apache/airflow/pull/7879#issuecomment-604146697
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7879:
[AIRFLOW-6399] Serialization: DAG access_control field should be decorated
field in DAG serialization
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7879: [AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization
URL: https://github.com/apache/airflow/pull/7879#issuecomment-604667373
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] lsimoneau commented on issue #7879: [AIRFLOW-6399]
Serialization: DAG access_control field should be decorated field in DAG
serialization
Posted by GitBox <gi...@apache.org>.
lsimoneau commented on issue #7879: [AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization
URL: https://github.com/apache/airflow/pull/7879#issuecomment-604193683
Seems like one of the builds timed out on a CLI test? The tests run green in Breeze on my machine so might just need a bump?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7879: [AIRFLOW-6399]
Serialization: DAG access_control field should be decorated field in DAG
serialization
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7879: [AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization
URL: https://github.com/apache/airflow/pull/7879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] lsimoneau commented on issue #7879: [AIRFLOW-6399]
Serialization: DAG access_control field should be decorated field in DAG
serialization
Posted by GitBox <gi...@apache.org>.
lsimoneau commented on issue #7879: [AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization
URL: https://github.com/apache/airflow/pull/7879#issuecomment-604718131
@kaxil thanks for that. Can I ask if you expect this to be released in a version before 2.0? We rely on serialisation for some of our cluster monitoring, and are trying to roll out RBAC now but this is a blocker. Otherwise we may try building off a fork for now, but wanted to check with you if there were more bugfix releases coming before 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services