You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/10/07 12:12:32 UTC

Review Request 39078: RANGER-681 : Update default sync intervals for LDAP and UNIX

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39078/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-681
    https://issues.apache.org/jira/browse/RANGER-681


Repository: ranger


Description
-------

Patch contains changes to update default sync intervals to sync users from LDAP and UNIX


Diffs
-----

  ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 7240fce840abfdc2e63dacb6e17c1e4bf8ef24c3 

Diff: https://reviews.apache.org/r/39078/diff/


Testing
-------

Tested on a cluster having Ranger and verified sync of users by changing the sync interval.


Thanks,

Gautam Borad


Re: Review Request 39078: RANGER-681 : Update default sync intervals for LDAP and UNIX

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39078/#review102561
-----------------------------------------------------------

Ship it!


Ship It!

- Velmurugan Periasamy


On Oct. 13, 2015, 11:41 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39078/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 11:41 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-681
>     https://issues.apache.org/jira/browse/RANGER-681
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Patch contains changes to update default sync intervals to sync users from LDAP and UNIX
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 7240fce840abfdc2e63dacb6e17c1e4bf8ef24c3 
> 
> Diff: https://reviews.apache.org/r/39078/diff/
> 
> 
> Testing
> -------
> 
> Tested on a cluster having Ranger and verified sync of users by changing the sync interval.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 39078: RANGER-681 : Update default sync intervals for LDAP and UNIX

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39078/
-----------------------------------------------------------

(Updated Oct. 13, 2015, 11:41 a.m.)


Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Updated default time for LDAP / AD to 1 hour


Bugs: RANGER-681
    https://issues.apache.org/jira/browse/RANGER-681


Repository: ranger


Description
-------

Patch contains changes to update default sync intervals to sync users from LDAP and UNIX


Diffs (updated)
-----

  ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 7240fce840abfdc2e63dacb6e17c1e4bf8ef24c3 

Diff: https://reviews.apache.org/r/39078/diff/


Testing
-------

Tested on a cluster having Ranger and verified sync of users by changing the sync interval.


Thanks,

Gautam Borad


Re: Review Request 39078: RANGER-681 : Update default sync intervals for LDAP and UNIX

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39078/#review102171
-----------------------------------------------------------



ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java (line 82)
<https://reviews.apache.org/r/39078/#comment159727>

    This min interval is too long. May be set it to 1 hour? Also it would be better if this can be made configurable as well.


- Velmurugan Periasamy


On Oct. 7, 2015, 10:12 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39078/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 10:12 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-681
>     https://issues.apache.org/jira/browse/RANGER-681
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Patch contains changes to update default sync intervals to sync users from LDAP and UNIX
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 7240fce840abfdc2e63dacb6e17c1e4bf8ef24c3 
> 
> Diff: https://reviews.apache.org/r/39078/diff/
> 
> 
> Testing
> -------
> 
> Tested on a cluster having Ranger and verified sync of users by changing the sync interval.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>