[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7687: video driver enhancements

[GitBox <gi...@apache.org>]

acassis commented on code in PR #7687:
URL: https://github.com/apache/incubator-nuttx/pull/7687#discussion_r1031863937


##########
video/Kconfig:
##########
@@ -13,6 +13,10 @@ config VIDEO
 
 if VIDEO
 
+config VIDEO_DEV_PATH
+	string "video device path"

Review Comment:
   Please use capitalized string: "Video Device Path"



##########
drivers/video/video.c:
##########
@@ -1161,6 +1162,15 @@ static int video_qbuf(FAR struct video_mng_s *vmng,
 
   memcpy(&container->buf, buf, sizeof(struct v4l2_buffer));
   video_framebuff_queue_container(&type_inf->bufinf, container);
+  if (g_video_data_ops->enq_buf)
+    {
+      ret = g_video_data_ops->enq_buf((uint8_t *)(uintptr_t)buf->m.userptr,
+          buf->length);

Review Comment:
   align buf->length); with the beginning of ( of previous line!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org