You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "bithw1 (via GitHub)" <gi...@apache.org> on 2026/01/07 07:05:39 UTC

[I] What's the benefit of async clean [hudi]

bithw1 opened a new issue, #17795:
URL: https://github.com/apache/hudi/issues/17795

   ### Describe the problem you faced
   
   Hi,
   
   In BaseHoodieWriteClient.java, `autoCleanOnCommit`  will be called by `postWrite` during a normal insert operation:
   
   ```
   
     protected void autoCleanOnCommit() {
       
       if (!config.isAutoClean()) {
         return;
       }
   
       
       if (config.isAsyncClean()) {
         LOG.info("Async cleaner has been spawned. Waiting for it to finish");
   
         //aync run clean in separate thread pool, but will be blocked until clean is finished
         tableServiceClient.asyncClean();
         LOG.info("Async cleaner has finished");
       } else {
         LOG.info("Start to clean synchronously.");
        
        //call clean() directly in the current thread     
         clean();
       }
     }
   
   ```
   
   ### To Reproduce
   
   1.
   2.
   3.
   4.
   
   
   ### Expected behavior
   
   1
   
   ### Environment Description
   
   1
   
   ### Additional context
   
   _No response_
   
   ### Stacktrace
   
   ```shell
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] What's the benefit of async clean [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on issue #17795:
URL: https://github.com/apache/hudi/issues/17795#issuecomment-3717735014

   The difference is async cleaning starts on `BaseHoodieWriteClient#preWrite` and completes here while the `clean` justs starts and wait for the ends.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] What's the benefit of async clean [hudi]

Posted by "bithw1 (via GitHub)" <gi...@apache.org>.
bithw1 commented on issue #17795:
URL: https://github.com/apache/hudi/issues/17795#issuecomment-3721384610

   > The difference is async cleaning starts on `BaseHoodieWriteClient#preWrite` and completes here while the `clean` justs starts and wait for the ends.
   
   Thanks a lot, @danny0405, I revisit the code, and you are right, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] What's the benefit of async clean [hudi]

Posted by "bithw1 (via GitHub)" <gi...@apache.org>.
bithw1 closed issue #17795: What's the benefit of async clean
URL: https://github.com/apache/hudi/issues/17795


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org