You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/16 11:14:22 UTC

[GitHub] [superset] michael-s-molina commented on a change in pull request #14139: chore: Moves Card to the components folder

michael-s-molina commented on a change in pull request #14139:
URL: https://github.com/apache/superset/pull/14139#discussion_r614758756



##########
File path: superset-frontend/src/components/Card/index.tsx
##########
@@ -17,23 +17,24 @@
  * under the License.
  */
 import React from 'react';
-import { styled } from '@superset-ui/core';
+import { SupersetTheme } from '@superset-ui/core';

Review comment:
       Here we are not using the theme object. It's just the theme type. The values are coming from the `ThemeProvider`.
   `css={(theme: SupersetTheme) => ({..})}`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org