You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/04 18:21:32 UTC
[GitHub] [geode] dschneider-pivotal opened a new pull request, #7654: GEODE-10196: handle 'Connection reset" for jdk17
dschneider-pivotal opened a new pull request, #7654:
URL: https://github.com/apache/geode/pull/7654
more handling of "Connection reset" instead of "Connection reset by peer" for jdk17
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on a diff in pull request #7654: GEODE-10196: handle 'Connection reset" for jdk17
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on code in PR #7654:
URL: https://github.com/apache/geode/pull/7654#discussion_r865149872
##########
geode-dunit/src/main/java/org/apache/geode/test/greplogs/ExpectedStrings.java:
##########
@@ -59,6 +59,7 @@ public static List<Pattern> create(String type) {
expected.add(Pattern.compile("Found expected warning"));
expected.add(Pattern.compile("CacheClosedException: The cache is closed."));
expected.add(Pattern.compile("Invoked MembershipNotifierHook"));
+ expected.add(Pattern.compile("java.io.IOException: Connection reset"));
Review Comment:
The ticket says that in JDK 17, the exception type is changed from `IOException` to `SocketException`. Should this be reflected here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #7654: GEODE-10196: handle 'Connection reset" for jdk17
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal closed pull request #7654: GEODE-10196: handle 'Connection reset" for jdk17
URL: https://github.com/apache/geode/pull/7654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a diff in pull request #7654: GEODE-10196: handle 'Connection reset" for jdk17
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on code in PR #7654:
URL: https://github.com/apache/geode/pull/7654#discussion_r865279394
##########
geode-dunit/src/main/java/org/apache/geode/test/greplogs/ExpectedStrings.java:
##########
@@ -59,6 +59,7 @@ public static List<Pattern> create(String type) {
expected.add(Pattern.compile("Found expected warning"));
expected.add(Pattern.compile("CacheClosedException: The cache is closed."));
expected.add(Pattern.compile("Invoked MembershipNotifierHook"));
+ expected.add(Pattern.compile("java.io.IOException: Connection reset"));
Review Comment:
Thanks. I made the expected pattern for connection reset more general to catch both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #7654: GEODE-10196: handle 'Connection reset" for jdk17
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on PR #7654:
URL: https://github.com/apache/geode/pull/7654#issuecomment-1119795329
redis was removed from geode so this pr is no longer needed in geode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org