[jira] [Commented] (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

["Hiroaki Kawai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599797#comment-13599797 ] 

Hiroaki Kawai commented on CLOUDSTACK-1638:
-------------------------------------------

created a patch as https://reviews.apache.org/r/9871/
                
> Network plugins won't be notified VM migration.
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-1638
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1638
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.2.0
>            Reporter: Hiroaki Kawai
>              Labels: patch
>
> The location of the virtual machine is provided by DeployDestination, which will be passed in NetworkGuru#reserve and NetworkElement#prepare.
> During the virtual machine migration, it actually changes DeployDestination and it looks like that it will tell that event to network components as it has NetworkManager#prepareNicForMigration. The problem is that althogh the interface has that method, NetworkManagerImpl does not tell the DeployDestination changes to network components.
> So IMHO, we need to add calls of NetworkGuru#reserve and NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And then, we also need to add calls NetworkGuru#release and NetworkElement#release after the migration, otherwise the network resources that plugin reserved will be kept even when the vm leaves off.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira