You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "archiewood (via GitHub)" <gi...@apache.org> on 2025/11/12 21:13:36 UTC
[PR] fix: dataZoom incorrectly filters stacked data [echarts]
archiewood opened a new pull request, #21372:
URL: https://github.com/apache/echarts/pull/21372
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: dataZoom incorrectly filters stacked data [echarts]
Posted by "archiewood (via GitHub)" <gi...@apache.org>.
archiewood commented on PR #21372:
URL: https://github.com/apache/echarts/pull/21372#issuecomment-3596862466
Let me know if there is anything you would like me to do here, for example the refactor I mentioned above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: dataZoom incorrectly filters stacked data [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #21372:
URL: https://github.com/apache/echarts/pull/21372#issuecomment-3523960041
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
Please **DO NOT** commit the files in [dist](https://github.com/apache/echarts/tree/master/dist), [i18n](https://github.com/apache/echarts/tree/master/i18n), and [ssr/client/dist](https://github.com/apache/echarts/tree/master/ssr/client/dist) folders in a non-release pull request. These folders are for release use only.
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: `PR: doc ready`, `PR: awaiting doc`, `PR: doc unchanged`
This message is shown because the PR description doesn't contain the document related template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: dataZoom incorrectly filters stacked data [echarts]
Posted by "archiewood (via GitHub)" <gi...@apache.org>.
archiewood commented on code in PR #21372:
URL: https://github.com/apache/echarts/pull/21372#discussion_r2543031710
##########
src/component/dataZoom/AxisProxy.ts:
##########
@@ -303,6 +304,10 @@ class AxisProxy {
return;
}
+ zrUtil.each(dataDims, function (dim, index) {
+ dataDims[index] = getStackedDimension(seriesData, dim);
Review Comment:
> This seems to be unexpected to me because this makes const dataDims = seriesData.mapDimensionsAll(axisDim); almost useless.
- The `mapDimensionsAll(axisDim)` call is necessary to get all dimensions that map to this axis.
- Then `getStackedDimension()` transforms each dimension to its stacked result dimension _**only**_ if that dimension is stacked - otherwise it returns the original dimension unchanged.
an alternative would be maybe to define dataDims like this, and then not overwrite the elements later, I was just concerned this would be less clear
```js
const dataDims = zrUtil.map(
seriesData.mapDimensionsAll(axisDim),
dim => getStackedDimension(seriesData, dim)
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: dataZoom incorrectly filters stacked data [echarts]
Posted by "archiewood (via GitHub)" <gi...@apache.org>.
archiewood commented on code in PR #21372:
URL: https://github.com/apache/echarts/pull/21372#discussion_r2543031710
##########
src/component/dataZoom/AxisProxy.ts:
##########
@@ -303,6 +304,10 @@ class AxisProxy {
return;
}
+ zrUtil.each(dataDims, function (dim, index) {
+ dataDims[index] = getStackedDimension(seriesData, dim);
Review Comment:
> This seems to be unexpected to me because this makes const dataDims = seriesData.mapDimensionsAll(axisDim); almost useless.
- The `mapDimensionsAll(axisDim)` call is necessary to get all dimensions that map to this axis.
- Then `getStackedDimension()` transforms each dimension to its stacked result dimension _**only**_ if that dimension is stacked - otherwise it returns the original dimension unchanged.
an alternative would be maybe to define dataDims like this, and then not overwrite the elements later, I was just concerned this would be less clear
```js
const dataDims = zrUtil.map(
seriesData.mapDimensionsAll(axisDim),
function(dim) {
return getStackedDimension(seriesData, dim);
}
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: dataZoom incorrectly filters stacked data [echarts]
Posted by "archiewood (via GitHub)" <gi...@apache.org>.
archiewood commented on PR #21372:
URL: https://github.com/apache/echarts/pull/21372#issuecomment-4193479913
This would help our project and i believe is a generally useful to the rest of the project. Let me know if there is anything else I can do to help get this over the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: dataZoom incorrectly filters stacked data [echarts]
Posted by "archiewood (via GitHub)" <gi...@apache.org>.
archiewood commented on PR #21372:
URL: https://github.com/apache/echarts/pull/21372#issuecomment-3549544173
updated to conform to PR teplate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: dataZoom incorrectly filters stacked data [echarts]
Posted by "archiewood (via GitHub)" <gi...@apache.org>.
archiewood commented on PR #21372:
URL: https://github.com/apache/echarts/pull/21372#issuecomment-3986031904
@100pah gentle nudge on this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: dataZoom incorrectly filters stacked data [echarts]
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on code in PR #21372:
URL: https://github.com/apache/echarts/pull/21372#discussion_r2541024672
##########
src/component/dataZoom/AxisProxy.ts:
##########
@@ -303,6 +304,10 @@ class AxisProxy {
return;
}
+ zrUtil.each(dataDims, function (dim, index) {
+ dataDims[index] = getStackedDimension(seriesData, dim);
Review Comment:
This seems to be unexpected to me because this makes `const dataDims = seriesData.mapDimensionsAll(axisDim);` almost useless.
Found [these comments](https://github.com/apache/echarts/pull/21372/files#diff-3854f78ad3bc536f752552ac1fbc9174156bf3dd879e1cf557efbdc039ce9dd2L277-L293) might be related. @100pah Please help review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: dataZoom incorrectly filters stacked data [echarts]
Posted by "archiewood (via GitHub)" <gi...@apache.org>.
archiewood commented on PR #21372:
URL: https://github.com/apache/echarts/pull/21372#issuecomment-3790644564
Hi all, let me know if this is of interest.
This would be beneficial for us as we are currently patching echarts to work around this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org