You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/08/11 08:20:28 UTC

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1427: ZOOKEEPER-3905: Race condition causes sessions to be created for clients even though their certificate authentication has failed (3.6)

nkalmar commented on a change in pull request #1427:
URL: https://github.com/apache/zookeeper/pull/1427#discussion_r468408083



##########
File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java
##########
@@ -22,7 +22,9 @@
 
 package org.apache.zookeeper.test;
 
+import java.io.IOException;
 import static org.junit.Assert.assertTrue;

Review comment:
       checkstyle don't like the order for this... yikes. 
   I guess Assert.fail should be before? Not sure why.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org