You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/23 05:24:53 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32631: [SPARK-35483][INFRA] Add docker-integration-tests to run-tests.py and GA.

HyukjinKwon commented on a change in pull request #32631:
URL: https://github.com/apache/spark/pull/32631#discussion_r637489244



##########
File path: dev/run-tests.py
##########
@@ -687,6 +689,10 @@ def main():
         test_modules = determine_modules_to_test(changed_modules)
         excluded_tags = determine_tags_to_exclude(changed_modules)
 
+    # Run docker-integration-tests only if it's explicitly specified.
+    if not opts.modules or modules.docker_integration_tests.name not in opts.modules:
+        excluded_tags.extend(modules.docker_integration_tests.test_tags)

Review comment:
       @sarutak, this way seems okay but how about doing it with similarly with other tests like Kinesis just for consistency?  (see `git grep -r "ENABLE_KINESIS_TESTS"`).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org