You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/03/28 03:06:23 UTC
Review Request 66325: Implemented idempotency for agent resource
provider config API calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66325/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
Bugs: MESOS-8742
https://issues.apache.org/jira/browse/MESOS-8742
Repository: mesos
Description
-------
`ADD_RESOURCE_PROVIDER_CONFIG`, `UPDATE_RESOURCE_PROVIDER_CONFIG` and
`REMOVE_RESOURCE_PROVIDER_CONFIG` now return 200 for identical
repetivite calls.
Diffs
-----
src/resource_provider/daemon.cpp d0a8186da80a1bffbb71f524e639bc7d75ef6243
src/slave/http.cpp 65081c95c888a8236aafdfc627a7aa4e9a72b65d
Diff: https://reviews.apache.org/r/66325/diff/1/
Testing
-------
make
NOTE: Test `*/AgentResourceProviderConfigApiTest.RemoveNotFound` won't pass since the semantics of `REMOVE_RESOURCE_PROVIDER_CONFIG` is changed.
Tests are added in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 66325: Implemented idempotency for agent resource
provider config API calls.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66325/#review200152
-----------------------------------------------------------
Fix it, then Ship it!
src/resource_provider/daemon.cpp
Line 274 (original), 285 (patched)
<https://reviews.apache.org/r/66325/#comment280803>
Why we need to return `bool`?
- Jie Yu
On March 28, 2018, 10:20 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66325/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 10:20 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-8742
> https://issues.apache.org/jira/browse/MESOS-8742
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `ADD_RESOURCE_PROVIDER_CONFIG`, `UPDATE_RESOURCE_PROVIDER_CONFIG` and
> `REMOVE_RESOURCE_PROVIDER_CONFIG` now return 200 for identical
> repetivite calls.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.cpp d0a8186da80a1bffbb71f524e639bc7d75ef6243
> src/resource_provider/storage/provider.cpp 8db1ce0589be2885cd970f029027fb73c5cbc09f
> src/slave/http.cpp 65081c95c888a8236aafdfc627a7aa4e9a72b65d
>
>
> Diff: https://reviews.apache.org/r/66325/diff/2/
>
>
> Testing
> -------
>
> make
>
> NOTE: Test `*/AgentResourceProviderConfigApiTest.RemoveNotFound` won't pass since the semantics of `REMOVE_RESOURCE_PROVIDER_CONFIG` is changed.
> Tests are added in the next patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66325: Implemented idempotency for agent resource
provider config API calls.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66325/
-----------------------------------------------------------
(Updated March 29, 2018, 2:10 a.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
Changes
-------
Addressed Jie's comment.
Bugs: MESOS-8742
https://issues.apache.org/jira/browse/MESOS-8742
Repository: mesos
Description
-------
`ADD_RESOURCE_PROVIDER_CONFIG`, `UPDATE_RESOURCE_PROVIDER_CONFIG` and
`REMOVE_RESOURCE_PROVIDER_CONFIG` now return 200 for identical
repetivite calls.
Diffs (updated)
-----
src/resource_provider/daemon.hpp a6d0013fa3645fd2b705351a86679f7fba13e7e3
src/resource_provider/daemon.cpp d0a8186da80a1bffbb71f524e639bc7d75ef6243
src/resource_provider/storage/provider.cpp 8db1ce0589be2885cd970f029027fb73c5cbc09f
src/slave/http.cpp 65081c95c888a8236aafdfc627a7aa4e9a72b65d
Diff: https://reviews.apache.org/r/66325/diff/3/
Changes: https://reviews.apache.org/r/66325/diff/2-3/
Testing
-------
make
NOTE: Test `*/AgentResourceProviderConfigApiTest.RemoveNotFound` won't pass since the semantics of `REMOVE_RESOURCE_PROVIDER_CONFIG` is changed.
Tests are added in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 66325: Implemented idempotency for agent resource
provider config API calls.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66325/
-----------------------------------------------------------
(Updated March 28, 2018, 10:20 p.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
Changes
-------
Added validations for `info.id` and made the quoting marks in error messages consistent.
Bugs: MESOS-8742
https://issues.apache.org/jira/browse/MESOS-8742
Repository: mesos
Description
-------
`ADD_RESOURCE_PROVIDER_CONFIG`, `UPDATE_RESOURCE_PROVIDER_CONFIG` and
`REMOVE_RESOURCE_PROVIDER_CONFIG` now return 200 for identical
repetivite calls.
Diffs (updated)
-----
src/resource_provider/daemon.cpp d0a8186da80a1bffbb71f524e639bc7d75ef6243
src/resource_provider/storage/provider.cpp 8db1ce0589be2885cd970f029027fb73c5cbc09f
src/slave/http.cpp 65081c95c888a8236aafdfc627a7aa4e9a72b65d
Diff: https://reviews.apache.org/r/66325/diff/2/
Changes: https://reviews.apache.org/r/66325/diff/1-2/
Testing
-------
make
NOTE: Test `*/AgentResourceProviderConfigApiTest.RemoveNotFound` won't pass since the semantics of `REMOVE_RESOURCE_PROVIDER_CONFIG` is changed.
Tests are added in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 66325: Implemented idempotency for agent resource
provider config API calls.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66325/#review200104
-----------------------------------------------------------
src/resource_provider/daemon.cpp
Line 186 (original), 187 (patched)
<https://reviews.apache.org/r/66325/#comment280750>
has RP ID already been brought into alignment here?
src/resource_provider/daemon.cpp
Lines 239 (patched)
<https://reviews.apache.org/r/66325/#comment280751>
ditto, has RP ID already been brought into alignment?
- James DeFelice
On March 28, 2018, 3:06 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66325/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 3:06 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-8742
> https://issues.apache.org/jira/browse/MESOS-8742
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `ADD_RESOURCE_PROVIDER_CONFIG`, `UPDATE_RESOURCE_PROVIDER_CONFIG` and
> `REMOVE_RESOURCE_PROVIDER_CONFIG` now return 200 for identical
> repetivite calls.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.cpp d0a8186da80a1bffbb71f524e639bc7d75ef6243
> src/slave/http.cpp 65081c95c888a8236aafdfc627a7aa4e9a72b65d
>
>
> Diff: https://reviews.apache.org/r/66325/diff/1/
>
>
> Testing
> -------
>
> make
>
> NOTE: Test `*/AgentResourceProviderConfigApiTest.RemoveNotFound` won't pass since the semantics of `REMOVE_RESOURCE_PROVIDER_CONFIG` is changed.
> Tests are added in the next patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>