[GitHub] apucher closed pull request #3533: [TE] roocause - fix dimension table metric select/unselect

[GitBox <gi...@apache.org>]

apucher closed pull request #3533: [TE] roocause - fix dimension table metric select/unselect
URL: https://github.com/apache/incubator-pinot/pull/3533
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js
index 29be3f1d8a..0e5969e97d 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js
+++ b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js
@@ -3,6 +3,7 @@ import Component from '@ember/component';
 import {
   toCurrentUrn,
   toBaselineUrn,
+  toMetricUrn,
   isInverse,
   toColorDirection,
   makeSortable,
@@ -125,7 +126,7 @@ export default Component.extend({
         Object.keys(current[name]).forEach(value => {
           if (value === ROOTCAUSE_VALUE_OTHER) { return; }
 
-          const urn = appendFilters(metricUrn, [[name, value]]);
+          const urn = appendFilters(metricUrn, [[name, '=', value]]);
           const curr = (current[name] || {})[value] || 0;
           const base = (baseline[name] || {})[value] || 0;
 
@@ -209,11 +210,7 @@ export default Component.extend({
       const urn = e.selectedItems[0].urn;
       const state = !selectedUrns.has(urn);
 
-      const updates = {[urn]: state};
-      if (hasPrefix(urn, 'thirdeye:metric:')) {
-        updates[toCurrentUrn(urn)] = state;
-        updates[toBaselineUrn(urn)] = state;
-      }
+      const updates = { [toMetricUrn(urn)]: state, [toCurrentUrn(urn)]: state, [toBaselineUrn(urn)]: state };
 
       set(this, 'preselectedItems', []);
       onSelection(updates);


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org