You are viewing a plain text version of this content. The canonical link for it is here.

Posted to npanday-commits@incubator.apache.org by br...@apache.org on 2014/07/09 04:24:32 UTC

svn commit: r1609010 - /incubator/npanday/trunk/components/dotnet-executable/src/main/java/npanday/executable/impl/DefaultRepositoryNetExecutable.java

Author: brett
Date: Wed Jul  9 04:24:31 2014
New Revision: 1609010

URL: http://svn.apache.org/r1609010
Log:
expand on comment

Modified:
    incubator/npanday/trunk/components/dotnet-executable/src/main/java/npanday/executable/impl/DefaultRepositoryNetExecutable.java

Modified: incubator/npanday/trunk/components/dotnet-executable/src/main/java/npanday/executable/impl/DefaultRepositoryNetExecutable.java
URL: http://svn.apache.org/viewvc/incubator/npanday/trunk/components/dotnet-executable/src/main/java/npanday/executable/impl/DefaultRepositoryNetExecutable.java?rev=1609010&r1=1609009&r2=1609010&view=diff
==============================================================================
--- incubator/npanday/trunk/components/dotnet-executable/src/main/java/npanday/executable/impl/DefaultRepositoryNetExecutable.java (original)
+++ incubator/npanday/trunk/components/dotnet-executable/src/main/java/npanday/executable/impl/DefaultRepositoryNetExecutable.java Wed Jul  9 04:24:31 2014
@@ -102,6 +102,7 @@ public class DefaultRepositoryNetExecuta
             );
         }
 
+        // TODO: find out under what situation this was needed and remove hard coding - can catch false positives (see MSBuild plugin need for /v:q), better to rely on exit code
         if ( commandExecutor.getStandardOut().contains( "error" ) && !commandExecutor.getStandardOut().contains(
             "exit code = 0"
         ) )