You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Eric Hauser (JIRA)" <ji...@apache.org> on 2011/08/20 05:19:27 UTC
[jira] [Created] (ZOOKEEPER-1158) C# client
C# client
---------
Key: ZOOKEEPER-1158
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
Project: ZooKeeper
Issue Type: Improvement
Reporter: Eric Hauser
Attachments: ZOOKEEPER-1158.patch
Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Maxime Brugidou (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255831#comment-13255831 ]
Maxime Brugidou commented on ZOOKEEPER-1158:
--------------------------------------------
Eric, the nuget.exe executable works on Mono. So we could use it to load the 2 referenced dlls. Although I haven't tested.
I did a pull request on your github in case you want to use that patch (https://github.com/ewhauser/zookeeper/pull/1).
The .NET zookeeper client is also available via NuGet at https://nuget.org/packages/ZooKeeperNet
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch, ZOOKEEPER-1158-09082011-2.patch, log4net.dll, nunit.framework.dll
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: ZOOKEEPER-1158_2.patch
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Attachments: ZOOKEEPER-1158.patch, ZOOKEEPER-1158_2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: (was: ZOOKEEPER-1158.patch)
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158_2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096707#comment-13096707 ]
Eric Hauser commented on ZOOKEEPER-1158:
----------------------------------------
Camille,
The patch makes is .NET 4.0 based. .NET 4.0 contains some lockless collections that lead to a significant performance improvement over the previous version of my client. If necessary, this could be handled using compiler flags. Although I have not testing this client vs. Mono, I know that the Avro project includes a nant script to compile and run their C# tests under mono.
I've concatenated the two patches and attached.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158_2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by Andrew Finnell <an...@gmail.com>.
I did not submit this patch but I have been following the patch process for a while as I am interested in this client. So I have some comments also:
> • Strong naming keys or dependent dll’s aren’t part of the patch but I think that’s likely due to the fact that patches can’t contain binaries but it does mean I had to source the dll’s from somewhere and disable strong naming for now.
The strong naming key should not be submitted or obtainable from source control. An extra step should be generated in a NAnt build file to sign the Assembly with a SNK on the build machine. This SNK should be held exclusively by Apache (ZooKeeper).
> • Tests require a locally running ZooKeeper server which is annoying and means there’s currently no way of running the tests automatically as the build.xml does nothing for .Net other than running jute.
I have a running build of ZooKeeper using IKVM that can be used to embed a QuorumPeer into unit testing. This process can be included in an updated NAnt build file in order to successfully test the client. However, this would take the C# client off the same process the other clients go through. The other clients must have a way to start ZK servers, correct?
The Assembly needs to be named Apache.ZooKeeper.Client as ZooKeeperNet does not adhere to any .NET naming standard.
I can fix most of these or work with Eric in doing so if needed. There isn't a mirror I can pull off for these as far as I can tell correct? It is a temporary build that applies the patch then runs through the tests? If not I'll fork from Eric's build.
Andrew
On Sep 6, 2011, at 10:28 AM, Camille Fournier (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098030#comment-13098030 ]
>
> Camille Fournier commented on ZOOKEEPER-1158:
> ---------------------------------------------
>
> Some comments from our side of the fence on the first patch, please disregard those that are not relevant with the updates:
>
> • After applying the patch, a lot of the files seem to have weird characters (maybe need a dos2unix?). I’ve seen them in svn diffs before so thought it may be normal but doesn’t seem like it. Had to manually remove them.
> • The csproj doesn’t fully correspond to the jute generated files; there’s an extra file required by the csproj which jute doesn’t generate. Luckily it’s not required by the code, just a bad csproj.
> • Mismatch between code and jute templates (jute generates ZooKeeperNet.Conversion but real namespace is ZooKeeperNet.IO).
> • Strong naming keys or dependent dll’s aren’t part of the patch but I think that’s likely due to the fact that patches can’t contain binaries but it does mean I had to source the dll’s from somewhere and disable strong naming for now.
> • One of the csproj’s has a reference to pnunit. I’ve no idea what it is but it doesn’t seem required. Again, bad csproj.
> • Some weird nunit stuff, he uses Assert.True but I’ve only ever seen (and the only version my nunit has) is Assert.IsTrue.
> • Tests require a locally running ZooKeeper server which is annoying and means there’s currently no way of running the tests automatically as the build.xml does nothing for .Net other than running jute.
>
>
> We did manage to work through these and get the unit tests to pass, so I think it's all quite promising. We also have a few small enhancements that we made over the old SharpKeeper that don't seem to exist here either but we can add those in once this is committed.
>
>> C# client
>> ---------
>>
>> Key: ZOOKEEPER-1158
>> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
>> Project: ZooKeeper
>> Issue Type: Improvement
>> Reporter: Eric Hauser
>> Assignee: Eric Hauser
>> Fix For: 3.5.0
>>
>> Attachments: ZOOKEEPER-1158-09032011.patch
>>
>>
>> Native C# client for ZooKeeper.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Camille Fournier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098030#comment-13098030 ]
Camille Fournier commented on ZOOKEEPER-1158:
---------------------------------------------
Some comments from our side of the fence on the first patch, please disregard those that are not relevant with the updates:
• After applying the patch, a lot of the files seem to have weird characters (maybe need a dos2unix?). I’ve seen them in svn diffs before so thought it may be normal but doesn’t seem like it. Had to manually remove them.
• The csproj doesn’t fully correspond to the jute generated files; there’s an extra file required by the csproj which jute doesn’t generate. Luckily it’s not required by the code, just a bad csproj.
• Mismatch between code and jute templates (jute generates ZooKeeperNet.Conversion but real namespace is ZooKeeperNet.IO).
• Strong naming keys or dependent dll’s aren’t part of the patch but I think that’s likely due to the fact that patches can’t contain binaries but it does mean I had to source the dll’s from somewhere and disable strong naming for now.
• One of the csproj’s has a reference to pnunit. I’ve no idea what it is but it doesn’t seem required. Again, bad csproj.
• Some weird nunit stuff, he uses Assert.True but I’ve only ever seen (and the only version my nunit has) is Assert.IsTrue.
• Tests require a locally running ZooKeeper server which is annoying and means there’s currently no way of running the tests automatically as the build.xml does nothing for .Net other than running jute.
We did manage to work through these and get the unit tests to pass, so I think it's all quite promising. We also have a few small enhancements that we made over the old SharpKeeper that don't seem to exist here either but we can add those in once this is committed.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088511#comment-13088511 ]
Mahadev konar commented on ZOOKEEPER-1158:
------------------------------------------
Eric,
Thanks for the submission. Would you be able to add more details to the patch? How does it work? How to use it? Does it use the C serialization or you added generation for C#?
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Attachments: ZOOKEEPER-1158.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: (was: ZOOKEEPER-1158-09082011.patch)
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch, ZOOKEEPER-1158-09082011-2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: ZOOKEEPER-1158-09032011.patch
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158_2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100864#comment-13100864 ]
Eric Hauser commented on ZOOKEEPER-1158:
----------------------------------------
New patch submitted addressing the issues listed above.
A couple of notes:
1. The additional binary assemblies have been added to the ticket and they need to be placed in src/dotnet/lib. As opposed to checking the assemblies in directly, we could just add reference using NuGet (.NET's Maven/Ivy equivalent). However, Andrew is working on a Mono build for this and I am not sure if NuGet works with Mono.
2. Having the strong named keys generated by a NAnt script sounds like a fine idea. I would probably prefer to commit this patch and address that in a follow up issue given the size of this patch.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch, ZOOKEEPER-1158-09082011-2.patch, ZOOKEEPER-1158-09082011.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095829#comment-13095829 ]
Hadoop QA commented on ZOOKEEPER-1158:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492697/ZOOKEEPER-1158_2.patch
against trunk revision 1164265.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/486//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/486//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/486//console
This message is automatically generated.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Attachments: ZOOKEEPER-1158.patch, ZOOKEEPER-1158_2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095711#comment-13095711 ]
Eric Hauser commented on ZOOKEEPER-1158:
----------------------------------------
It is a native C# port of the Java client that uses support for C# that was added to jute. In most cases, the API was intentionally keep the same as the Java client in order to make future porting easier.
I've added a second patch that adds the code generation necessary to compile to build.xml.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Attachments: ZOOKEEPER-1158.patch, ZOOKEEPER-1158_2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: ZOOKEEPER-1158.patch
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Attachments: ZOOKEEPER-1158.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: ZOOKEEPER-1158-09082011-2.patch
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch, ZOOKEEPER-1158-09082011-2.patch, ZOOKEEPER-1158-09082011.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097228#comment-13097228 ]
Patrick Hunt commented on ZOOKEEPER-1158:
-----------------------------------------
it might be the some of the files (csproj for example) may not support adding license details, if that's the case please update build.xml with the exclusions in releaseaudit target.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: ZOOKEEPER-1158-09032011.patch
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: (was: ZOOKEEPER-1158-09032011.patch)
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158_2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Camille Fournier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098284#comment-13098284 ]
Camille Fournier commented on ZOOKEEPER-1158:
---------------------------------------------
One other comment:
The Perms values are currently static rather than const. It would be better if they were const so we could use them in switch statements.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1158:
------------------------------------
Fix Version/s: 3.5.0
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158.patch, ZOOKEEPER-1158_2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1158) C# client
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-1158:
----------------------------------------
Assignee: Eric Hauser
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Attachments: ZOOKEEPER-1158.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Joshua Garvin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143523#comment-13143523 ]
Joshua Garvin commented on ZOOKEEPER-1158:
------------------------------------------
I'm curious if anyone can tell me when this patch will be added to the repository. I could really use this code and when I checked out the repository and tried to apply the attached patches, it told me there was an unknown line type on line 4738.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch, ZOOKEEPER-1158-09082011-2.patch, log4net.dll, nunit.framework.dll
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by Patrick Hunt <ph...@apache.org>.
Hi Andrew. If we can get the code to run successfully with Mono then
we'd can open an INFRA jira to make that happen (we don't admin the
Jenkins servers - builds@ handles that)
See this as an example of such a request:
https://issues.apache.org/jira/browse/INFRA-3842
In this case the request would have to be tailored to "install mono on
Jenkins", etc...
Patrick
On Fri, Sep 2, 2011 at 8:18 AM, Andrew Finnell <an...@gmail.com> wrote:
> There is an alternative to a Windows .NET build system. You can use Mono on the existing Hudson Linux machine. I can setup a build file that will build the client, if someone is able to install at least 2.10.4 of Mono on the server and set MONO_HOME.
>
> Andrew
>
> On Sep 2, 2011, at 10:38 AM, Camille Fournier (JIRA) wrote:
>
>>
>> [ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096015#comment-13096015 ]
>>
>> Camille Fournier commented on ZOOKEEPER-1158:
>> ---------------------------------------------
>>
>> Eric,
>>
>> Very exciting, thanks so much for pushing this back. I think we need to get a .NET build for our build farm. We're already working on a windows C++ build so hopefully this won't be too difficult. Which version of .NET is this written against, 4.0?
>> I'm going to have my team here try to apply and compile the patch. We use 3.5 though, so not sure we will be successful. Either way I think we can do the code review since we're already using the old SharpKeeper
>>
>> BTW, the second patch should probably be submitted on top of the first, instead of as a separate thing.
>>
>>> C# client
>>> ---------
>>>
>>> Key: ZOOKEEPER-1158
>>> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
>>> Project: ZooKeeper
>>> Issue Type: Improvement
>>> Reporter: Eric Hauser
>>> Assignee: Eric Hauser
>>> Attachments: ZOOKEEPER-1158.patch, ZOOKEEPER-1158_2.patch
>>>
>>>
>>> Native C# client for ZooKeeper.
>>
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>
>
Re: [jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by Andrew Finnell <an...@gmail.com>.
There is an alternative to a Windows .NET build system. You can use Mono on the existing Hudson Linux machine. I can setup a build file that will build the client, if someone is able to install at least 2.10.4 of Mono on the server and set MONO_HOME.
Andrew
On Sep 2, 2011, at 10:38 AM, Camille Fournier (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096015#comment-13096015 ]
>
> Camille Fournier commented on ZOOKEEPER-1158:
> ---------------------------------------------
>
> Eric,
>
> Very exciting, thanks so much for pushing this back. I think we need to get a .NET build for our build farm. We're already working on a windows C++ build so hopefully this won't be too difficult. Which version of .NET is this written against, 4.0?
> I'm going to have my team here try to apply and compile the patch. We use 3.5 though, so not sure we will be successful. Either way I think we can do the code review since we're already using the old SharpKeeper
>
> BTW, the second patch should probably be submitted on top of the first, instead of as a separate thing.
>
>> C# client
>> ---------
>>
>> Key: ZOOKEEPER-1158
>> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
>> Project: ZooKeeper
>> Issue Type: Improvement
>> Reporter: Eric Hauser
>> Assignee: Eric Hauser
>> Attachments: ZOOKEEPER-1158.patch, ZOOKEEPER-1158_2.patch
>>
>>
>> Native C# client for ZooKeeper.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Camille Fournier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096015#comment-13096015 ]
Camille Fournier commented on ZOOKEEPER-1158:
---------------------------------------------
Eric,
Very exciting, thanks so much for pushing this back. I think we need to get a .NET build for our build farm. We're already working on a windows C++ build so hopefully this won't be too difficult. Which version of .NET is this written against, 4.0?
I'm going to have my team here try to apply and compile the patch. We use 3.5 though, so not sure we will be successful. Either way I think we can do the code review since we're already using the old SharpKeeper
BTW, the second patch should probably be submitted on top of the first, instead of as a separate thing.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Attachments: ZOOKEEPER-1158.patch, ZOOKEEPER-1158_2.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: ZOOKEEPER-1158-09082011.patch
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch, ZOOKEEPER-1158-09082011.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096719#comment-13096719 ]
Hadoop QA commented on ZOOKEEPER-1158:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492907/ZOOKEEPER-1158-09032011.patch
against trunk revision 1164758.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 36 release audit warnings (more than the trunk's current 24 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//console
This message is automatically generated.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: nunit.framework.dll
log4net.dll
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch, ZOOKEEPER-1158-09082011-2.patch, log4net.dll, nunit.framework.dll
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143532#comment-13143532 ]
Flavio Junqueira commented on ZOOKEEPER-1158:
---------------------------------------------
Joshua, This issue is marked for 3.5.0, so it should go into the next release, not the one we are working on currently.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch, ZOOKEEPER-1158-09082011-2.patch, log4net.dll, nunit.framework.dll
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1158) C# client
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088121#comment-13088121 ]
Hadoop QA commented on ZOOKEEPER-1158:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12491031/ZOOKEEPER-1158.patch
against trunk revision 1159432.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 34 release audit warnings (more than the trunk's current 24 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//console
This message is automatically generated.
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Attachments: ZOOKEEPER-1158.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1158) C# client
Posted by "Eric Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hauser updated ZOOKEEPER-1158:
-----------------------------------
Attachment: (was: ZOOKEEPER-1158_2.patch)
> C# client
> ---------
>
> Key: ZOOKEEPER-1158
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Eric Hauser
> Assignee: Eric Hauser
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1158-09032011.patch
>
>
> Native C# client for ZooKeeper.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira