You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/16 09:15:44 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
EricGao888 opened a new pull request, #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477
## Purpose of the pull request
* Apply [micrometer naming convention](https://github.com/micrometer-metrics/micrometer-docs/blob/main/src/docs/concepts/naming.adoc#:~:text=Micrometer%20employs%20a%20naming%20convention,between%20one%20system%20and%20another.) to DS metrics for future portability and compatibility.
* For detailed explanation, refer to [Naming Convention section](https://docs.qq.com/doc/DTGFiSkRIbHBIeVp3)
* This PR closes: #10432
## Brief change log
* :warning: Still WIP. I only updated metrics exposed by worker server and haven't updated docs. If it looks fine, I will proceed with the left ones.
* This PR will add docs related to naming convention / name mapping in the following commits.
* This PR will add Chinese version docs for metrics in the following commits.
## Verify this pull request
Verified by manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#issuecomment-1160470978
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10477)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10477&metric=new_coverage&view=list) [61.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10477&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10477&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10477&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#issuecomment-1159899942
> > Do we have a way to unify the formats of customize metrics as well as default metrics (like `jvm_gc_pause_seconds_max`, etc.)? Otherwise the defaults still don't follow the micrometer naming convention.
>
> @kezhenxu94 Thanks for pointing this out. Actually those default metrics DO follow the naming convention. If we check `http://ip:port/actuator/metrics`, we could get the list of metrics' names before mapping. We will see those default metrics as . The reason why in this PR it looks different is that this PR is still a draft and WIP. I haven't updated the docs yet. Sorry for the confusion.
Nice if that's the case! LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#issuecomment-1159818683
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10477)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10477&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10477&metric=new_coverage&view=list) [51.9% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10477&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10477&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10477&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#issuecomment-1157465516
Could u plz take a look when you have time? @ruanwenjun Thx~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#discussion_r898921559
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/metrics/WorkerServerMetrics.java:
##########
@@ -30,13 +30,13 @@ public WorkerServerMetrics() {
}
private static final Counter WORKER_OVERLOAD_COUNTER =
- Counter.builder("dolphinscheduler_worker_overload_count")
- .description("worker load count")
+ Counter.builder("ds.system.worker.overload.count")
+ .description("overloaded workers count")
.register(Metrics.globalRegistry);
private static final Counter WORKER_SUBMIT_QUEUE_IS_FULL_COUNTER =
- Counter.builder("dolphinscheduler_worker_submit_queue_is_full_count")
- .description("worker task submit queue is full count")
+ Counter.builder("ds.system.worker.full.submit.queue.count")
Review Comment:
Sure, will remove `system`, since it might cause some ambiguities with jvm / network level stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#discussion_r901671675
##########
docs/docs/en/guide/metrics/metrics.md:
##########
@@ -1,154 +1,168 @@
# Introduction
-Apache DolphinScheduler has export some metrics to monitor the system. We use micrometer for the exporter facade, and
-the default exporter is prometheus, more exporter is coming soon.
+Apache DolphinScheduler exports metrics for system observability. We use [Micrometer](https://micrometer.io/) as application metrics facade.
+Currently, we only support `Prometheus Exporter` but more are coming soon.
-## Quick Start
+## Quick Start
-You can add the following config in master/worker/alert/api's yaml file to open the metrics exporter.
-
-```yaml
-metrics:
- enabled: true
-```
-
-Once you open the metrics exporter, you can access the metrics by the url: `http://ip:port/actuator/prometheus`
-
-The exporter port is the `server.port` defined in application.yaml, e.g: master: `server.port: 5679`, worker: `server.port: 1235`, alert: `server.port: 50053`, api: `server.port: 12345`.
-
-For example, you can get the master metrics by `curl http://localhost:5679/actuator/prometheus`
-
-We have prepared the out-of-the-box Grafana configuration for you, you can find the Grafana dashboard
-at `dolphinscheduler-meter/resources/grafana`, you can directly import these dashboards to grafana.
-
-If you want to try at docker, you can use the following command to start the prometheus with grafana:
+- We enable Apache DolphinScheduler export metrics in `standalone` mode to help users get hands dirty easily.
Review Comment:
```suggestion
- We enable Apache DolphinScheduler to export metrics in `standalone` mode to help users get hands dirty easily.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#issuecomment-1159901819
> > > Do we have a way to unify the formats of customize metrics as well as default metrics (like `jvm_gc_pause_seconds_max`, etc.)? Otherwise the defaults still don't follow the micrometer naming convention.
> >
> >
> > @kezhenxu94 Thanks for pointing this out. Actually those default metrics DO follow the naming convention. If we check `http://ip:port/actuator/metrics`, we could get the list of metrics' names before mapping. We will see those default metrics as . The reason why in this PR it looks different is that this PR is still a draft and WIP. I haven't updated the docs yet. Sorry for the confusion.
>
> Nice if that's the case! LGTM
@kezhenxu94 Somehow I just couldn't fall asleep last night. So I got up very early this morning, wrote some code and docs, committed and pushed them to find some peace and went to bed again. Haven't finished it yet, lol. I will complete this PR later today. :rofl:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun merged pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#issuecomment-1159817619
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10477?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10477](https://codecov.io/gh/apache/dolphinscheduler/pull/10477?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a45b9e6) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/2c227ab3849b50e2fac508c458a8b9b36a073159?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2c227ab) will **decrease** coverage by `0.00%`.
> The diff coverage is `43.33%`.
```diff
@@ Coverage Diff @@
## dev #10477 +/- ##
============================================
- Coverage 40.86% 40.85% -0.01%
+ Complexity 4849 4848 -1
============================================
Files 886 886
Lines 36009 36032 +23
Branches 3994 3998 +4
============================================
+ Hits 14716 14722 +6
- Misses 19835 19850 +15
- Partials 1458 1460 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ler/server/master/metrics/MasterServerMetrics.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9tZXRyaWNzL01hc3RlclNlcnZlck1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...nscheduler/service/process/ProcessServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZUltcGwuamF2YQ==) | `30.76% <ø> (ø)` | |
| [...inscheduler/server/worker/metrics/TaskMetrics.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9tZXRyaWNzL1Rhc2tNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ler/server/worker/metrics/WorkerServerMetrics.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9tZXRyaWNzL1dvcmtlclNlcnZlck1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../server/worker/processor/TaskExecuteProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVQcm9jZXNzb3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...inscheduler/plugin/task/zeppelin/ZeppelinTask.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stemVwcGVsaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svemVwcGVsaW4vWmVwcGVsaW5UYXNrLmphdmE=) | `48.68% <34.37%> (-7.92%)` | :arrow_down: |
| [.../server/master/metrics/ProcessInstanceMetrics.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9tZXRyaWNzL1Byb2Nlc3NJbnN0YW5jZU1ldHJpY3MuamF2YQ==) | `62.50% <85.71%> (ø)` | |
| [...inscheduler/server/master/metrics/TaskMetrics.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9tZXRyaWNzL1Rhc2tNZXRyaWNzLmphdmE=) | `69.44% <100.00%> (ø)` | |
| [...duler/plugin/task/zeppelin/ZeppelinParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stemVwcGVsaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svemVwcGVsaW4vWmVwcGVsaW5QYXJhbWV0ZXJzLmphdmE=) | `84.61% <100.00%> (+7.69%)` | :arrow_up: |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/dolphinscheduler/pull/10477/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10477?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10477?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [704e633...a45b9e6](https://codecov.io/gh/apache/dolphinscheduler/pull/10477?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#issuecomment-1159884718
> Do we have a way to unify the formats of customize metrics as well as default metrics (like `jvm_gc_pause_seconds_max`, etc.)? Otherwise the defaults still don't follow the micrometer naming convention.
@kezhenxu94 Thanks for pointing this out. Actually those default metrics DO follow the naming convention. If we check `http://ip:port/actuator/metrics`, we could get the list of metrics' names before mapping. We will see those default metrics as
. The reason why in this PR it looks different is that this PR is still a drap and WIP. I haven't updated the docs yet. Sorry for the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #10477: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #10477:
URL: https://github.com/apache/dolphinscheduler/pull/10477#discussion_r898919097
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/metrics/WorkerServerMetrics.java:
##########
@@ -30,13 +30,13 @@ public WorkerServerMetrics() {
}
private static final Counter WORKER_OVERLOAD_COUNTER =
- Counter.builder("dolphinscheduler_worker_overload_count")
- .description("worker load count")
+ Counter.builder("ds.system.worker.overload.count")
+ .description("overloaded workers count")
.register(Metrics.globalRegistry);
private static final Counter WORKER_SUBMIT_QUEUE_IS_FULL_COUNTER =
- Counter.builder("dolphinscheduler_worker_submit_queue_is_full_count")
- .description("worker task submit queue is full count")
+ Counter.builder("ds.system.worker.full.submit.queue.count")
Review Comment:
How about remove the system?
```suggestion
Counter.builder("ds.worker.full.submit.queue.count")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org