You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/20 14:49:07 UTC

[GitHub] [activemq-artemis] ehsavoie opened a new pull request #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader

ehsavoie opened a new pull request #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader
URL: https://github.com/apache/activemq-artemis/pull/2987
 
 
   * Fixing Postgresql JDBC store when the driver is not directly accessible or when using a connection pool.
   The postgresql dedicated code in Artemis suppose that the connection is a 'direct' connection from the driver. This may not always be the case and thus the connection needs to be unwrapped and if a different classloader is used then use reflection to use it.
   
   Jira: https://issues.apache.org/jira/browse/ARTEMIS-2626
   
   Supersedes https://github.com/apache/activemq-artemis/pull/2948

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader
URL: https://github.com/apache/activemq-artemis/pull/2987#issuecomment-589235625
 
 
   Nice !!!   I thought about something simple. You went beyond complete now.  Thanks a lot. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] ehsavoie commented on issue #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader

Posted by GitBox <gi...@apache.org>.
ehsavoie commented on issue #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader
URL: https://github.com/apache/activemq-artemis/pull/2987#issuecomment-589229746
 
 
   Is this better ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] asfgit merged pull request #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader
URL: https://github.com/apache/activemq-artemis/pull/2987
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader
URL: https://github.com/apache/activemq-artemis/pull/2987#issuecomment-589179230
 
 
   It's just that when I look for a list of commits, I like to understand what was changed.. to follow cherry-picks.. etc..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader
URL: https://github.com/apache/activemq-artemis/pull/2987#issuecomment-589178920
 
 
   @ehsavoie sort of a nit-pic but the only thing wrong here is the title for the commit
   
   the bug is Postgres JDBC requires JDBC driver..
   
   
   The fix is... allowing Postgres to use the driver in a certain way... etc..
   
   
   Can you be a bit more descriptive of the fix itself instead of using the bug description?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] asfgit closed pull request #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2987: [ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader
URL: https://github.com/apache/activemq-artemis/pull/2987
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services