You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "0yukali0 (via GitHub)" <gi...@apache.org> on 2023/02/14 06:27:47 UTC
[GitHub] [yunikorn-k8shim] 0yukali0 opened a new pull request, #530: [YUNIKORN-1571] cleanup old plugin deployment examples
0yukali0 opened a new pull request, #530:
URL: https://github.com/apache/yunikorn-k8shim/pull/530
### What is this PR for?
Removing unused config in plugin.yaml example
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
* [x] - Tasks
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1571
### How should this be tested?
### Screenshots (if appropriate)
<img width="818" alt="image" src="https://user-images.githubusercontent.com/45888688/218656363-59b1b2e5-1ecc-40d5-b71e-f8b9315cb07c.png">
<img width="938" alt="image" src="https://user-images.githubusercontent.com/45888688/218656476-991cf068-ec36-49d4-9c95-b2bff2c18ecc.png">
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #530: [YUNIKORN-1571] cleanup old plugin deployment examples
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #530:
URL: https://github.com/apache/yunikorn-k8shim/pull/530#issuecomment-1429200570
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/530?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#530](https://codecov.io/gh/apache/yunikorn-k8shim/pull/530?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4c7dee) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/22a00a1940224192c1386d80933a477c5691939d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22a00a1) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
- Coverage 69.55% 69.52% -0.03%
==========================================
Files 45 45
Lines 7715 7715
==========================================
- Hits 5366 5364 -2
- Misses 2153 2155 +2
Partials 196 196
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/530?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/530?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] 0yukali0 commented on a diff in pull request #530: [YUNIKORN-1571] cleanup old plugin deployment examples
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on code in PR #530:
URL: https://github.com/apache/yunikorn-k8shim/pull/530#discussion_r1106571609
##########
deployments/scheduler/plugin.yaml:
##########
@@ -96,8 +97,6 @@ spec:
cpu: 4
memory: 2Gi
volumeMounts:
- - mountPath: /etc/kubernetes
- name: scheduler-config
- mountPath: /etc/yunikorn
name: quotamanager-config
Review Comment:
Hi @wilfred-s , you are right and I will remove this in next commit.
After I removed the quatamanager-config, latest yunikorn will use the default configuration here.
<img width="547" alt="image" src="https://user-images.githubusercontent.com/45888688/218907959-7dd7f59a-dad7-4cfd-bff8-91d915d855a2.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on a diff in pull request #530: [YUNIKORN-1571] cleanup old plugin deployment examples
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #530:
URL: https://github.com/apache/yunikorn-k8shim/pull/530#discussion_r1106588655
##########
deployments/scheduler/plugin.yaml:
##########
@@ -96,8 +97,6 @@ spec:
cpu: 4
memory: 2Gi
volumeMounts:
- - mountPath: /etc/kubernetes
- name: scheduler-config
- mountPath: /etc/yunikorn
name: quotamanager-config
Review Comment:
That looks correct, let's see if we have got this all correct and get a review from Craig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on a diff in pull request #530: [YUNIKORN-1571] cleanup old plugin deployment examples
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #530:
URL: https://github.com/apache/yunikorn-k8shim/pull/530#discussion_r1106499829
##########
deployments/scheduler/plugin.yaml:
##########
@@ -96,8 +97,6 @@ spec:
cpu: 4
memory: 2Gi
volumeMounts:
- - mountPath: /etc/kubernetes
- name: scheduler-config
- mountPath: /etc/yunikorn
name: quotamanager-config
Review Comment:
With the new configuration v2 do we need these?
I could not find any mounting beside the secrets for the admission controller in the current helm charts.
@craigcondit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #530: [YUNIKORN-1571] cleanup old plugin deployment examples
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #530: [YUNIKORN-1571] cleanup old plugin deployment examples
URL: https://github.com/apache/yunikorn-k8shim/pull/530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org