You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2023/05/05 22:07:34 UTC
[GitHub] [couchdb] nickva opened a new pull request, #4576: Encapsulate MD5 file checksums bits in couch_file
nickva opened a new pull request, #4576:
URL: https://github.com/apache/couchdb/pull/4576
Avoid leaking checksumming details into couch_bt_engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #4576: Encapsulate MD5 file checksums bits in couch_file
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #4576:
URL: https://github.com/apache/couchdb/pull/4576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #4576: Encapsulate MD5 file checksums bits in couch_file
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #4576:
URL: https://github.com/apache/couchdb/pull/4576#issuecomment-1536884877
@chewbranca good observation it does couple couch_file to md5, but it's already coupled as we're verifying md5 checksums in there. This was one case were we pretended we could pass in an external checksum but we still assumed it had to be md5 and verified it as such. After this PR we can keep the detail hidden inside couch_file basically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org