[GitHub] [airflow] syedahsn commented on pull request #30853: Change Deferrable implementation for RedshiftPauseClusterOperator to follow standard

["syedahsn (via GitHub)" <gi...@apache.org>]

syedahsn commented on PR #30853:
URL: https://github.com/apache/airflow/pull/30853#issuecomment-1533857104

   Thanks @potiuk for the idea about handling the error from the waiter to log a status message! I've been playing around that for a bit, and I have a solution that produces the following logs for this operator:
   ```
   [2023-05-03, 22:53:07 UTC] {base.py:73} INFO - Using connection ID 'aws_default' for task execution.
   [2023-05-03, 22:53:07 UTC] {credentials.py:617} INFO - Found credentials in shared credentials file: ~/.aws/credentials
   [2023-05-03, 22:53:15 UTC] {redshift_cluster.py:200} INFO - Status of cluster is pausing
   [2023-05-03, 22:53:53 UTC] {redshift_cluster.py:200} INFO - Status of cluster is pausing
   [2023-05-03, 22:54:32 UTC] {redshift_cluster.py:200} INFO - Status of cluster is pausing
   [2023-05-03, 22:55:10 UTC] {redshift_cluster.py:200} INFO - Status of cluster is pausing
   [2023-05-03, 22:55:48 UTC] {triggerer_job_runner.py:615} INFO - Trigger example_redshift/manual__2023-05-03T22:44:17.762920+00:00/pause_cluster/-1/1 (ID 2) fired: TriggerEvent<{'status': 'success', 'message': 'Cluster paused'}>
   ```
   This will need to be implemented on all boto waiters if we want them to log messages during the polling period, until boto waiters support logging natively. 
   
   I've opened an [issue](https://github.com/boto/botocore/issues/2923) with botocore requesting a logging feature. We'll have to see if/when they choose to add it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org