[GitHub] [daffodil] stevedlawrence commented on pull request #972: Update occursIndex to skip absent elements

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence commented on PR #972:
URL: https://github.com/apache/daffodil/pull/972#issuecomment-1448550336

   > I wonder if it would be worth moving checks that aren't specific to OS and JDK versions into their own "lint" job inside main.yml?
   
   Agreed. It would also make the OS/JDK jobs finish 1-2 minutes quicker. Not a huge difference, but the quicker tests finish the better. The new job could also be configured to always run all checks even if one fails.
   
   > At that time it would also be nice to see if we can have the tests run in a docker container with all the dependencies and configurations installed and ready-to-go.
   
   I wouldn't want to have to maintain multiple docker images for CI tests. We already have 7 different OS/JDK combinations we have. Though I agree that a dev container could be useful. Though, most of the dependency work is handled by sbt which is straightforward to install. I think the only deps it doesn't handle is gcc and MiniXML dep, which I think most distros already provide.
   
   Whatever is decided can all be done as a separate PR though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org