You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Andreas Lehmkühler (JIRA)" <ji...@apache.org> on 2014/01/05 16:44:51 UTC

[jira] [Resolved] (PDFBOX-1831) [PATCH] Fix: "Foreign" characters are not rendered

     [ https://issues.apache.org/jira/browse/PDFBOX-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Lehmkühler resolved PDFBOX-1831.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0
         Assignee: Andreas Lehmkühler

I added the proposed patch in revision 1555529 with some slight changes:

- the deprecated endchar command may occur with 4 and 5 numbers, the origin patch handles only the 5 number case correct
- some reformatting

A big thanks for the contribution!

> [PATCH] Fix: "Foreign" characters are not rendered
> --------------------------------------------------
>
>                 Key: PDFBOX-1831
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1831
>             Project: PDFBox
>          Issue Type: Bug
>          Components: FontBox
>    Affects Versions: 2.0.0
>            Reporter: John Hewson
>            Assignee: Andreas Lehmkühler
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: 1822-agb.pdf-3.png, StandardEncoding.java, Type1CharString.java, Type2CharString.java, diff.patch
>
>
> This is a patch to fix PDFBOX-1691, I've opened it as its own issue because it's quite a large patch.
> The issue it fixes is that the Type 1 "seac" command was not implemented. Seac is a command which draws a composite glyph from two other glyphs. This requires that the Type 1 renderer has access to any of the other rendered glyphs in a CFFFont, which is why this patch is non-trivial. The major change is that the CharStringRenderer has been refactored into a new Type1CharString class and the CharStringConverter has been refactored into a new Type2CharString class. A lot of code has been moved around, but overall this is a conservative patch, as most of the code has not changed significantly.
> As well as the patch, there are 3 new files:
> + fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java
> + fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java
> + fontbox/src/main/java/org/apache/fontbox/encoding/StandardEncoding.java
> and two deleted files:
> - fontbox/src/main/java/org/apache/fontbox/cff/CharStringRenderer.java
> - fontbox/src/main/java/org/apache/fontbox/cff/CharStringConverter.java



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)